From: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: "Andrej Ota" <andrej@ota.si>,
"Paweł Staszewski" <pstaszewski@itcare.pl>,
"Andrew Morton" <akpm@linux-foundation.org>,
netdev@vger.kernel.org, "Paul Mackerras" <paulus@samba.org>,
bugzilla-daemon@bugzilla.kernel.org,
bugme-daemon@bugzilla.kernel.org, pstaszewski@artcom.pl,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"David Miller" <davem@davemloft.net>,
"Gorik Van Steenberge" <gvs@zemos.net>,
"Daniel Kenzelmann" <kernel.bugzilla@kenzelmann.dyndns.info>
Subject: Re: [PATCH] pppoe.c: Fix kernel panic caused by __pppoe_xmit
Date: Sun, 12 Dec 2010 23:02:09 +0200 [thread overview]
Message-ID: <201012122302.10330.nuclearcat@nuclearcat.com> (raw)
In-Reply-To: <20101211200823.GA1917@del.dom.local>
On Saturday 11 December 2010 22:08:23 Jarek Poplawski wrote:
> On Sat, Dec 11, 2010 at 01:44:38PM +0100, Andrej Ota wrote:
> > __pppoe_xmit function return value was invalid resulting in
> > additional call to kfree_skb on already freed skb. This resulted in
> > memory corruption and consequent kernel panic after PPPoE peer
> > terminated the link.
> >
> > This fixes commit 55c95e738da85373965cb03b4f975d0fd559865b.
> >
> > Signed-off-by: Jarek Poplawski [jarkao2@gmail.com]
> > Signed-off-by: Andrej Ota [andrej@ota.si]
> > Reported-by: Pawel Staszewski [pstaszewski@artcom.pl]
>
> Thanks Andrej! I've only updated emails a bit.
> Jarek P.
>
> Reported-by: Gorik Van Steenberge <gvs@zemos.net>
> Reported-by: Daniel Kenzelmann <kernel.bugzilla@kenzelmann.dyndns.info>
> Reported-by: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
> Reported-by: Pawel Staszewski <pstaszewski@artcom.pl>
> Diagnosed-by: Andrej Ota <andrej@ota.si>
> Diagnosed-by: Eric Dumazet <eric.dumazet@gmail.com>
> Tested-by: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
> Tested-by: Pawel Staszewski <pstaszewski@artcom.pl>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> Signed-off-by: Andrej Ota <andrej@ota.si>
Thanks a lot!
prev parent reply other threads:[~2010-12-12 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101210091505.GA7868@ff.dom.local>
2010-12-10 14:49 ` [PATCH] [Bug 24472] Kernel panic - not syncing: Fatal Exception Andrej Ota
2010-12-10 15:55 ` Jarek Poplawski
[not found] ` <4D037236.4080903@ota.si>
2010-12-11 20:08 ` [PATCH] pppoe.c: Fix kernel panic caused by __pppoe_xmit Jarek Poplawski
2010-12-11 23:23 ` Andrej Ota
2010-12-12 23:06 ` David Miller
2010-12-12 21:02 ` Denys Fedoryshchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012122302.10330.nuclearcat@nuclearcat.com \
--to=nuclearcat@nuclearcat.com \
--cc=akpm@linux-foundation.org \
--cc=andrej@ota.si \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gvs@zemos.net \
--cc=jarkao2@gmail.com \
--cc=kernel.bugzilla@kenzelmann.dyndns.info \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=pstaszewski@artcom.pl \
--cc=pstaszewski@itcare.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.