From: Jean-Francois Moine <moinejf@free.fr>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17
Date: Mon, 13 Dec 2010 20:15:05 +0100 [thread overview]
Message-ID: <20101213201505.756f930d@tele> (raw)
In-Reply-To: <4D061F3C.8060101@redhat.com>
On Mon, 13 Dec 2010 11:27:24 -0200
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> > case SENSOR_OV7660:
> > init = ov7660_sensor_param1;
> > - if (sd->bridge == BRIDGE_SN9C120) {
> > - if (mode) { /* 320x240 - 160x120 */
> > - reg17 = 0xa2;
> > - reg1 = 0x44; /* 48 Mhz, video trf eneble */
> > - }
> > - } else {
> > - reg17 = 0x22;
> > - reg1 = 0x06; /* 24 Mhz, video trf eneble
> > - * inverse power down */
> > - }
>
> I'm not sure about this... On my tests with the two devices I have
> with ov7660 (sn9c105 and sn9c120), the original driver uses 48 MHz
> for all resolutions.
Hi Mauro,
You are right, I will fix that in the next version.
Regards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2010-12-13 19:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 13:04 [PATCH 6/6] gspca - sonixj: Better handling of the bridge registers 0x01 and 0x17 Jean-Francois Moine
2010-12-13 13:27 ` Mauro Carvalho Chehab
2010-12-13 18:44 ` Hans de Goede
2010-12-13 19:15 ` Jean-Francois Moine [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-14 19:17 Jean-François Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213201505.756f930d@tele \
--to=moinejf@free.fr \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.