From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan-Hendrik Zab Subject: Re: drm/i915: unconditionally unlock panel regs Date: Tue, 14 Dec 2010 23:15:28 +0100 Message-ID: <20101214221528.GA61196@jhz.name> References: <20101214121759.11b8aa3a@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from jhz.name (red.unix-ag.uni-hannover.de [130.75.176.204]) by gabe.freedesktop.org (Postfix) with ESMTP id 934699E76E for ; Tue, 14 Dec 2010 14:41:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <20101214121759.11b8aa3a@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 14/12/10 12:17 -0800, Jesse Barnes wrote: > In the panel_on function we skip everything if the panel is already > powered up. However, if it's powered up but not unlocked, subsequent > register writes may fail. > > So unlock the regs regardless of the panel state to allow other mode > setting programming to occur normally. > > [Still waiting to hear from bug reporters & testers on this one, but > it does get my Vaio working again, with or without the eDP VBT patch > reverted.] My Vaio VPCZ1 works with your patch in addition to the eDP VBT patch (or rather the revert reverted). It does not work without the eDP VBT patch. The above is true for drm-intel-next and drm-intel-fixes. -jhz -- http://jhz.name/blog