From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: <git@vger.kernel.org>, Bo Yang <struggleyb.nku@gmail.com>
Subject: Re: [PATCH 1/8] Refactor parse_loc
Date: Wed, 15 Dec 2010 00:06:12 +0100 [thread overview]
Message-ID: <201012150006.12462.trast@student.ethz.ch> (raw)
In-Reply-To: <7v8vzsrmhk.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
> > +test_expect_success 'blame -L parses end' '
> > + git blame -L1,1 tres >out &&
> > + cat out &&
> > + test $(wc -l < out) -eq 1
> > +'
>
> What does this test exactly? "end"?
That's the test I was referring to in the commit message:
The new test is for a case that made me pause during debugging: the
'blame -L with invalid end' test was the only one that noticed an
outright failure to parse the end *at all*. So make a more explicit
test for that.
So I guess a more thorough test title would be
blame -L parses <end> part of its argument
IOW, the test verifies that -L1,1 is not parsed the same as -L1, which
would result in *two* lines of output.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-12-14 23:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 2:03 [PATCH v6 0/8] git log -L, cleaned up and (hopefully) fixed Thomas Rast
2010-12-14 2:03 ` [PATCH 1/8] Refactor parse_loc Thomas Rast
2010-12-14 22:57 ` Junio C Hamano
2010-12-14 23:06 ` Thomas Rast [this message]
2010-12-14 23:20 ` Junio C Hamano
2010-12-14 2:03 ` [PATCH 2/8] Export three functions from diff.c Thomas Rast
2010-12-14 23:08 ` Junio C Hamano
2010-12-14 2:03 ` [PATCH 3/8] Export rewrite_parents() for 'log -L' Thomas Rast
2010-12-14 2:03 ` [PATCH 4/8] Implement line-history search (git log -L) Thomas Rast
2010-12-14 2:03 ` [PATCH 5/8] log -L: support parent rewriting Thomas Rast
2010-12-14 2:03 ` [PATCH 6/8] log -L: add --graph prefix before output Thomas Rast
2010-12-14 2:03 ` [PATCH 7/8] log -L: add --full-line-diff option Thomas Rast
2010-12-14 2:03 ` [PATCH 8/8] log -L: implement move/copy detection (-M/-C) Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012150006.12462.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=struggleyb.nku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.