From: Olof Johansson <olof@lixom.net>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: zhangfei gao <zhangfei.gao@gmail.com>,
Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/4] sdhci: add quirk for broken sdio irq
Date: Wed, 15 Dec 2010 05:24:54 -0600 [thread overview]
Message-ID: <20101215112454.GA2086@lixom.net> (raw)
In-Reply-To: <20101215110312.GE3515@pengutronix.de>
On Wed, Dec 15, 2010 at 12:03:12PM +0100, Wolfram Sang wrote:
>
> > > Really appreciate if not using the valuable quirk resource, which is u32.
> >
> > No big deal. Next person that needs a quirk bit gets to bump the data
> > type to u64.
>
> That won't scale for long, I fear (and will make sdhci.c an unreadable
> mess). We need less quirks and more flexible means to handle flawed
> controllers, I'd think.
It won't scale for long, but it'll give a buffer while a cleaned up
quirk structure can be hashed out and implemented.
There are already a handful of quirks in there that can be trivially
moved into their respective drivers by overriding the register read/write
functions (like I already have for a couple on sdhci-tegra). Some of
the others are not obvious to me how they can be easily abstracted out
without adding even more callbacks up and down the stack for adding hooks.
-Olof
next prev parent reply other threads:[~2010-12-15 11:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 4:49 [PATCH 0/4] Add SDHCI driver for Tegra Olof Johansson
2010-12-15 4:49 ` [PATCH 1/4] sdhci: add quirk for max len ADMA descriptors Olof Johansson
2010-12-15 4:49 ` [PATCH 2/4] sdhci: add quirk for broken sdio irq Olof Johansson
2010-12-15 10:42 ` zhangfei gao
2010-12-15 10:54 ` Olof Johansson
2010-12-15 11:03 ` Wolfram Sang
2010-12-15 11:24 ` Olof Johansson [this message]
2010-12-15 11:44 ` Wolfram Sang
2010-12-15 10:57 ` Wolfram Sang
2010-12-15 11:34 ` Olof Johansson
2010-12-15 4:49 ` [PATCH 3/4] sdhci: don't finish commands in flight Olof Johansson
2010-12-15 4:49 ` [PATCH 4/4] mmc: add sdhci-tegra driver for Tegra SoCs Olof Johansson
2010-12-15 8:35 ` Wolfram Sang
2010-12-15 8:43 ` Olof Johansson
2010-12-15 8:46 ` Olof Johansson
2010-12-15 10:37 ` Wolfram Sang
2010-12-15 11:40 ` Olof Johansson
2010-12-15 11:59 ` Wolfram Sang
2010-12-15 13:03 ` Olof Johansson
2010-12-15 13:40 ` Wolfram Sang
2010-12-15 11:23 ` Mike Rapoport
2010-12-15 11:31 ` Olof Johansson
2010-12-15 11:33 ` Pavan Kondeti
2010-12-15 11:35 ` Olof Johansson
2010-12-15 11:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215112454.GA2086@lixom.net \
--to=olof@lixom.net \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=w.sang@pengutronix.de \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.