From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH][TOOLS] libxl: open code basename() Date: Wed, 15 Dec 2010 13:38:36 +0100 Message-ID: <201012151338.37043.Christoph.Egger@amd.com> References: <201012151312.59779.Christoph.Egger@amd.com> <4D08B35A.7060200@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D08B35A.7060200@ts.fujitsu.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Juergen Gross Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Wednesday 15 December 2010 13:23:54 Juergen Gross wrote: > On 12/15/10 13:12, Christoph Egger wrote: > > Hi! > > > > Attached patch open codes basename() with strrchr(). > > Fixes build on platforms like NetBSD where POSIX basename is available. > > > > Signed-off-by: Christoph Egger > > > > diff -r dcb46110d460 -r e8ce7e3e4b8c tools/libxl/xl_cmdimpl.c > > --- a/tools/libxl/xl_cmdimpl.c > > +++ b/tools/libxl/xl_cmdimpl.c > > @@ -5455,7 +5455,7 @@ int main_cpupoolcreate(int argc, char ** > > if (!xlu_cfg_get_string (config, "name", &buf)) > > name = strdup(buf); > > else > > - name = basename(filename); > > + name = strrchr(filename, '/') + 1; > > if (!libxl_name_to_cpupoolid(&ctx, name, &poolid)) { > > fprintf(stderr, "Pool name \"%s\" already exists\n", name); > > return -ERROR_FAIL; > > This is not correct. > strrchr returns NULL here if filename contains no '/'. This leads to name > being 1. Thanks for pointing this out. I haven't considered that case. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632