From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] pvops: fix "xm save -c" issue Date: Wed, 15 Dec 2010 10:40:21 -0500 Message-ID: <20101215154021.GB28984@dumpdata.com> References: <4D070138.7090708@jp.fujitsu.com> <20101214145925.GA5769@dumpdata.com> <4D08417E.7060104@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D08417E.7060104@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kenji Wakamiya Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Dec 15, 2010 at 01:18:06PM +0900, Kenji Wakamiya wrote: > Hi Konrad, thank you for your response, > > Konrad Rzeszutek Wilk wrote: > >On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote: > >>Hi, > >> > >>I'm investigating the issue of "xm save -c" in case of PV guests. > >>Then, I tried to prevent calling dpm_resume_end() when suspend was > >>canceled. It seems to work fine about blk and net. > >>How about this? > > > > > >Could you give more details of what the failure is? > > "xm save -c" saves domain state to storage and leaves it running after > creating snapshot. When this command is executed for a pvops > guest (xen/stable-2.6.32.x), the guest will hang up after accessing to > devices. > > When the guest is unapused, stop_machine() in manage.c returns as the > suspend is cancelled. In that case, I think dpm_resume_end() should > not be called after stop_machine(). > > I tested vbd and net, the guest did not hang. OK. Does 'xm save' (so no -c) and then resume work with this patch (I would think so, but I am curious whether you tested this). > But I'm not sure if this is a right way... Looks OK to me, just want to make sure that the normal 'xm save' still works after this.