Re: [PATCH] patch fix-rx-packets-accounting

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Dec 14, 2010 at 05:38:00PM +0000, Paul Durrant wrote:

Shouldn't there also be a patch to move the tx_bytes?

> ---
>  drivers/xen/netback/netback.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c
> index 1a4a20e..066d140 100644
> --- a/drivers/xen/netback/netback.c
> +++ b/drivers/xen/netback/netback.c
> @@ -1519,9 +1519,6 @@ static void net_tx_submit(struct xen_netbk *netbk)
>  		skb->dev      = netif->dev;
>  		skb->protocol = eth_type_trans(skb, skb->dev);
>  
> -		netif->stats.rx_bytes += skb->len;
> -		netif->stats.rx_packets++;
> -
>  		if (skb->ip_summed == CHECKSUM_PARTIAL) {
>  			if (skb_checksum_setup(skb)) {
>  				DPRINTK("Can't setup checksum in net_tx_action\n");
> @@ -1537,6 +1534,9 @@ static void net_tx_submit(struct xen_netbk *netbk)
>  			continue;
>  		}
>  
> +		netif->stats.rx_bytes += skb->len;
> +		netif->stats.rx_packets++;
> +
>  		netif_rx_ni(skb);
>  		netif->dev->last_rx = jiffies;
>  	}
> -- 
> 1.5.6.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel