From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.186]:54779 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752945Ab0LOPez (ORCPT ); Wed, 15 Dec 2010 10:34:55 -0500 From: Arnd Bergmann Subject: Re: [PATCH 7/7] msm: Build support for the MSM8960 target Date: Wed, 15 Dec 2010 16:34:53 +0100 References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1292384961-8851-8-git-send-email-stepanm@codeaurora.org> In-Reply-To: <1292384961-8851-8-git-send-email-stepanm@codeaurora.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201012151634.53301.arnd@arndb.de> Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: linux-arm-kernel@lists.infradead.org Cc: Stepan Moskovchenko , davidb@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday 15 December 2010, Stepan Moskovchenko wrote: > Add the Kconfig options and Makefile options needed to > build for the MSM8960 target. Only the simulator is > supported at this time. > > Signed-off-by: Stepan Moskovchenko There is no need to split the Makefile/Kconfig changes from the actual files implementing the functionality. It's better to keep these together, since neither of the patches does anything meaningful by itself. Splitting out the cleanup as you did is good though, it helps with review and with possible bisection or rebase of the patches. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 15 Dec 2010 16:34:53 +0100 Subject: [PATCH 7/7] msm: Build support for the MSM8960 target In-Reply-To: <1292384961-8851-8-git-send-email-stepanm@codeaurora.org> References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1292384961-8851-8-git-send-email-stepanm@codeaurora.org> Message-ID: <201012151634.53301.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 15 December 2010, Stepan Moskovchenko wrote: > Add the Kconfig options and Makefile options needed to > build for the MSM8960 target. Only the simulator is > supported at this time. > > Signed-off-by: Stepan Moskovchenko There is no need to split the Makefile/Kconfig changes from the actual files implementing the functionality. It's better to keep these together, since neither of the patches does anything meaningful by itself. Splitting out the cleanup as you did is good though, it helps with review and with possible bisection or rebase of the patches. Arnd