Re: [PATCH 00/22] rtl8192ce: Initial upload of driver

["John W. Linville" <linville@tuxdriver.com>]

On Wed, Dec 15, 2010 at 05:26:40PM +0100, Johannes Berg wrote:

> > If you prefer that it go to staging first, I will send it to GregKH, but since
> > it uses mac80211, I think it is ready for wireless.
> 
> It looks pretty clean -- so personally, I don't think I'd mind it going
> in directly.
> 
> Are you or somebody else planning to make changes to it though? It looks
> like for example the config semaphore could easily be replaced by a
> mutex for better debug, for example. Potentially, rate control could be
> internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some
> similar minor things.

Sorry for the delay, Larry!  I've been meaning to post a thorough
review, but...busy, busy...

Anyway, I think Johannes is right -- whatever issues remain, it
would be better to get it in place now than to leave it out or push
it to staging.

I intend to mash the series together into a single patch when I merge
it -- I hope you don't mind.

Thanks,

JOhn
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.