From: Gustavo F. Padovan <padovan@profusion.mobi>
To: ofono@ofono.org
Subject: Re: [PATCH] ctm: use ofono_error instead of DBG for errors
Date: Wed, 15 Dec 2010 19:47:04 -0200 [thread overview]
Message-ID: <20101215214704.GC3746@vigoh> (raw)
In-Reply-To: <87zks6d92v.fsf@ossau.uklinux.net>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
Hi Neil,
* Neil Jerram <neil@ossau.uklinux.net> [2010-12-15 21:23:20 +0000]:
> "Gustavo F. Padovan" <padovan@profusion.mobi> writes:
>
> > [PATCH] ctm: use ofono_error instead of DBG for errors
>
> I'm a newcomer to ofono, and to this list, but in general I'd hope to
> see more explanation/justification of code changes than this patch
> provides. In other words, why is it better to use ofono_error instead
> of DBG?
This patch fixes situation where we were reporting error in DBG messages.
If we have an error to print it is good to give the right priority to the
message. Just look the patch and you will figure out this.
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2010-12-15 21:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 21:06 [PATCH] ctm: use ofono_error instead of DBG for errors Gustavo F. Padovan
2010-12-15 21:23 ` Neil Jerram
2010-12-15 21:47 ` Gustavo F. Padovan [this message]
2010-12-15 22:00 ` Neil Jerram
2010-12-16 14:47 ` Lucas De Marchi
2010-12-16 18:04 ` [PATCH] " Gustavo F. Padovan
2010-12-17 16:29 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215214704.GC3746@vigoh \
--to=padovan@profusion.mobi \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.