From: "John W. Linville" <linville@tuxdriver.com>
To: Jouni Malinen <j@w1.fi>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] nl80211: Add notification for dropped Deauth/Disassoc
Date: Wed, 15 Dec 2010 16:56:11 -0500 [thread overview]
Message-ID: <20101215215610.GH2377@tuxdriver.com> (raw)
In-Reply-To: <20101214084133.GA28466@jm.kir.nu>
On Tue, Dec 14, 2010 at 10:41:33AM +0200, Jouni Malinen wrote:
> Add a new notification to indicate that a received, unprotected
> Deauthentication or Disassociation frame was dropped due to
> management frame protection being in use. This notification is
> needed to allow user space (e.g., wpa_supplicant) to implement
> SA Query procedure to recover from association state mismatch
> between an AP and STA.
>
> This is needed to avoid getting stuck in non-working state when MFP
> (IEEE 802.11w) is used and a protected Deauthentication or
> Disassociation frame is dropped for any reason. After that, the
> station would silently discard any unprotected Deauthentication or
> Disassociation frame that could be indicating that the AP does not
> have association for the STA (when the Reason Code would be 6 or 7).
> IEEE Std 802.11w-2009, 11.13 describes this recovery mechanism.
>
> Signed-off-by: Jouni Malinen <j@w1.fi>
>
> ---
> include/linux/nl80211.h | 10 ++++++++++
> net/mac80211/rx.c | 22 ++++++++++++++++++++--
> net/wireless/mlme.c | 22 ++++++++++++++++++++++
> net/wireless/nl80211.c | 16 ++++++++++++++++
> net/wireless/nl80211.h | 6 ++++++
> 5 files changed, 74 insertions(+), 2 deletions(-)
> --- wireless-testing.orig/net/wireless/mlme.c 2010-12-13 23:35:46.000000000 -0800
> +++ wireless-testing/net/wireless/mlme.c 2010-12-14 10:23:56.000000000 -0800
> @@ -263,6 +263,28 @@ void cfg80211_send_disassoc(struct net_d
> }
> EXPORT_SYMBOL(cfg80211_send_disassoc);
>
> +void cfg80211_send_unprot_deauth(struct net_device *dev, const u8 *buf,
> + size_t len)
> +{
> + struct wireless_dev *wdev = dev->ieee80211_ptr;
> + struct wiphy *wiphy = wdev->wiphy;
> + struct cfg80211_registered_device *rdev = wiphy_to_dev(wiphy);
> +
> + nl80211_send_unprot_deauth(rdev, dev, buf, len, GFP_ATOMIC);
> +}
> +EXPORT_SYMBOL(cfg80211_send_unprot_deauth);
> +
> +void cfg80211_send_unprot_disassoc(struct net_device *dev, const u8 *buf,
> + size_t len)
> +{
> + struct wireless_dev *wdev = dev->ieee80211_ptr;
> + struct wiphy *wiphy = wdev->wiphy;
> + struct cfg80211_registered_device *rdev = wiphy_to_dev(wiphy);
> +
> + nl80211_send_unprot_disassoc(rdev, dev, buf, len, GFP_ATOMIC);
> +}
> +EXPORT_SYMBOL(cfg80211_send_unprot_disassoc);
> +
> static void __cfg80211_auth_remove(struct wireless_dev *wdev, const u8 *addr)
> {
> int i;
Need cfg80211.h bits for these, no?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-15 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 22:00 [PATCH] nl80211: Add notification for dropped Deauth/Disassoc Jouni Malinen
2010-12-14 7:15 ` Johannes Berg
2010-12-14 7:46 ` Jouni Malinen
2010-12-14 7:48 ` Johannes Berg
2010-12-14 7:51 ` Johannes Berg
2010-12-14 7:54 ` Johannes Berg
2010-12-14 8:41 ` [PATCH v2] " Jouni Malinen
2010-12-15 21:56 ` John W. Linville [this message]
2010-12-15 22:49 ` Jouni Malinen
2010-12-15 22:52 ` [PATCH v3] " Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101215215610.GH2377@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.