From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Mariusz Kozlowski <mk@lab.zgora.pl>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rculist: fix borked __list_for_each_rcu() macro
Date: Thu, 16 Dec 2010 15:38:40 +0800 [thread overview]
Message-ID: <20101216073840.GA5313@cr0.nay.redhat.com> (raw)
In-Reply-To: <20101216060236.GB4826@mako-laptop>
On Thu, Dec 16, 2010 at 07:02:36AM +0100, Mariusz Kozlowski wrote:
>On Wed, Dec 15, 2010 at 03:20:05PM -0800, Paul E. McKenney wrote:
>> On Wed, Dec 15, 2010 at 11:11:12PM +0100, Mariusz Kozlowski wrote:
>> > This restores parentheses blance.
>>
>> Good catch, queued!!!
>>
>> This does not actually appear to be in use anywhere in the kernel any
>> more, so I queued this for 2.6.38 rather than in the 2.6.37 urgent queue.
>> So, just out of curiosity, how did you find this one?
>
>Some years ago I wrote a dumb script that walks trees of () and {}.
>It catches unbalanced trees. It's dumb enough to fail with #ifdef etc,
>but most of the time it does its job. It reaches unreachable code
>and unused one too.
>
gcc will complain about this, however, in this case, it is used.
next prev parent reply other threads:[~2010-12-16 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 22:11 [PATCH] rculist: fix borked __list_for_each_rcu() macro Mariusz Kozlowski
2010-12-15 23:20 ` Paul E. McKenney
2010-12-16 6:02 ` Mariusz Kozlowski
2010-12-16 7:38 ` Américo Wang [this message]
2010-12-16 15:50 ` Paul E. McKenney
2010-12-17 10:10 ` Américo Wang
2010-12-17 15:54 ` Paul E. McKenney
2010-12-16 15:51 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216073840.GA5313@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mk@lab.zgora.pl \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.