From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon (dme1737): cleanups
Date: Thu, 16 Dec 2010 15:32:27 +0000 [thread overview]
Message-ID: <20101216153227.GA7943@ericsson.com> (raw)
In-Reply-To: <AANLkTimTbiT_swuiyaHP9rLmN2iUfqPyu_gfq16QY-zv@mail.gmail.com>
On Thu, Dec 16, 2010 at 05:21:40AM -0500, Juerg Haefliger wrote:
> Minor cleanups. Mostly removing assignments in if statements to get
> rid of checkpatch errors.
>
> Signed-off-by: Juerg Haefliger <juergh at gmail.com>
Just wondering ... did you run this patch through checkpatch ?
I did, and got 11 warnings for the unnecessary use of { }.
Not sure if getting rid of checkpatch errors is worth it if you just
replace the errors with warnings.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-12-16 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 10:21 [lm-sensors] [PATCH 2/2] hwmon (dme1737): cleanups Juerg Haefliger
2010-12-16 15:32 ` Guenter Roeck [this message]
2010-12-16 15:46 ` Juerg Haefliger
2011-01-09 21:02 ` Jean Delvare
2011-01-10 1:37 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216153227.GA7943@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.