From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] do_memory_op: cleanup if copy_to_guest fails
Date: Thu, 16 Dec 2010 20:18:59 +0100
Message-ID: <20101216191859.GA28302@aepfle.de>
References: <20101216175910.GA24006@aepfle.de>
 <C9300BAE.29659%keir@xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <C9300BAE.29659%keir@xen.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xen.org>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Thu, Dec 16, Keir Fraser wrote:

> Leaving a bit of a mess on failed copy_to_guest is okay imo, as that is
> usually a pretty fatal sign anyway. If there were good reason for cleaning
> up better, we should at least be doing if (test_and_clear(PGC_allocated))
> put_page().

Yes, it would leak just a page and from what I have seen, the Linux
drivers will BUG() most of the time anyway if the hypercall fails.
So I will drop this from my series.

Olaf