From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clocksource: sh_cmt: Remove nested spinlock fix
Date: Fri, 17 Dec 2010 10:42:13 +0000 [thread overview]
Message-ID: <20101217104212.GF20847@linux-sh.org> (raw)
In-Reply-To: <20101217072509.32699.95165.sendpatchset@t400s>
On Fri, Dec 17, 2010 at 04:25:09PM +0900, Magnus Damm wrote:
> From: Takashi YOSHII <takashi.yoshii.zj@renesas.com>
>
> There are control flow that sh_cmt_set_next() does double
> spin-lock. The callers sh_cmt_{start,stop}() already have
> lock. But another callers sh_cmt_clock_event_{start,next}()
> does not.
>
> Now sh_cmt_set_next() does not lock by itself. All the
> callers should hold spin-lock before calling it.
>
> [damm@opensource.se: use __sh_cmt_set_next() to simplify code]
> [damm@opensource.se: added stable, suitable for v2.6.35 + v2.6.36]
> Cc: stable@kernel.org
> Signed-off-by: Takashi YOSHII <takashi.yoshii.zj@renesas.com>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Applied to sh/urgent, thanks.
prev parent reply other threads:[~2010-12-17 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 7:25 [PATCH] clocksource: sh_cmt: Remove nested spinlock fix Magnus Damm
2010-12-17 10:42 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217104212.GF20847@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.