From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: regression from c/s 22071:c5aed2e049bc (ept: Put locks around ept_get_entry) ? Date: Fri, 17 Dec 2010 15:03:53 +0100 Message-ID: <20101217140353.GA8762@aepfle.de> References: <4D0A516B0200007800028755@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: George Dunlap , Christoph Egger , "xen-devel@lists.xensource.com" , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Thu, Dec 16, Keir Fraser wrote: > Excellent. I will lay groundwork and fix pte_{read,write}_atomic directly= in > -unstable and -4.0-testing. I will then post a proposed fix for EPT to the > list. I don't know that code so well and I may not otherwise catch all > places that require use of the new accessor macros. Keir, this failure may be related to the changes that went just into xen-unstable, fails in openSuSE 11.2 and 11.3 on 32bit: make[2]:=E2=80=82Entering=E2=80=82directory=E2=80=82`/usr/src/packages/BUIL= D/xen-unstable.hg-4.1.22571/xen/arch/x86' gcc=E2=80=82-fomit-frame-pointer=E2=80=82-fmessage-length=3D0=E2=80=82-O2= =E2=80=82-Wall=E2=80=82 -D_FORTIFY_SOURCE=3D2=E2=80=82-fstack-protector=E2= =80=82-funwind-tables=E2=80=82 -fasynchronous-unwind-tables=E2=80=82-O1=E2= =80=82-fno-omit-frame-pointer=E2=80=82 -fno-optimize-sibling-calls=E2=80=82= -m32=E2=80=82-march=3Di686=E2=80=82-g=E2=80=82-fno-strict-aliasing=E2=80=82= -std=3Dgnu99=E2=80=82-Wall=E2=80=82-Wstrict-prototypes=E2=80=82-Wno-unused= -value=E2=80=82 -Wdeclaration-after-statement=E2=80=82=E2=80=82-nostdinc=E2= =80=82-fno-builtin=E2=80=82-fno-common=E2=80=82 -Wredundant-decls=E2=80=82-= iwithprefix=E2=80=82include=E2=80=82-Werror=E2=80=82-Wno-pointer-arith=E2= =80=82-pipe=E2=80=82 -I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xe= n/include=E2=80=82=E2=80=82 -I/usr/src/packages/BUILD/xen-unstable.hg-4.1.2= 2571/xen/include/asm-x86/mach-generic =E2=80=82 -I/usr/src/packages/BUILD/x= en-unstable.hg-4.1.22571/xen/include/asm-x86/mach-default =E2=80=82-msoft-f= loat=E2=80=82-fno-stack-protector=E2=80=82-fno-exceptions=E2=80=82-g=E2=80= =82-D__XEN__=E2=80=82 -DVERBOSE=E2=80=82-DCRASH_DEBUG=E2=80=82-fno-omit-fra= me-pointer=E2=80=82-DCONFIG_FRAME_POINTER=E2=80=82 -DMAX_PHYS_CPUS=3D32=E2= =80=82-MMD=E2=80=82-MF=E2=80=82.xen.d=E2=80=82-O1=E2=80=82-fno-omit-frame-p= ointer=E2=80=82 -fno-optimize-sibling-calls=E2=80=82-m32=E2=80=82-march=3Di= 686=E2=80=82-g=E2=80=82-fno-strict-aliasing=E2=80=82 -std=3Dgnu99=E2=80=82-= Wall=E2=80=82-Wstrict-prototypes=E2=80=82-Wno-unused-value=E2=80=82 -Wdecla= ration-after-statement=E2=80=82=E2=80=82-nostdinc=E2=80=82-fno-builtin=E2= =80=82-fno-common=E2=80=82 -Wredundant-decls=E2=80=82-iwithprefix=E2=80=82i= nclude=E2=80=82-Werror=E2=80=82-Wno-pointer-arith=E2=80=82-pipe=E2=80=82 -I= /usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include=E2=80=82=E2= =80=82 -I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm-= x86/mach-generic =E2=80=82 -I/usr/src/packages/BUILD/xen-unstable.hg-4.1.22= 571/xen/include/asm-x86/mach-default =E2=80=82-msoft-float=E2=80=82-fno-sta= ck-protector=E2=80=82-fno-exceptions=E2=80=82-g=E2=80=82-D__XEN__=E2=80=82 = -DVERBOSE=E2=80=82-DCRASH_DEBUG=E2=80=82-fno-omit-frame-pointer=E2=80=82-DC= ONFIG_FRAME_POINTER=E2=80=82 -DMAX_PHYS_CPUS=3D32=E2=80=82-MMD=E2=80=82-MF= =E2=80=82.asm-offsets.s.d=E2=80=82-S=E2=80=82-o=E2=80=82asm-offsets.s=E2=80= =82 x86_32/asm-offsets.c cc1:=E2=80=82warnings=E2=80=82being=E2=80=82treated=E2=80=82as=E2=80=82erro= rs In=E2=80=82file=E2=80=82included=E2=80=82from=E2=80=82/usr/src/packages/BUI= LD/xen-unstable.hg-4.1.22571/xen/include/asm/spinlock.h:6, =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80= =82from=E2=80=82/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/inclu= de/xen/spinlock.h:6, =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80= =82from=E2=80=82/usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/inclu= de/xen/sched.h:7, =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80= =82from=E2=80=82x86_32/asm-offsets.c:9: /usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm/atomic.h:= =E2=80=82In=E2=80=82function=E2=80=82'atomic_write64': /usr/src/packages/BUILD/xen-unstable.hg-4.1.22571/xen/include/asm/atomic.h:= 39:=E2=80=82error:=E2=80=82operation=E2=80=82on=E2=80=82'old'=E2=80=82may= =E2=80=82be=E2=80=82undefined make[2]:=E2=80=82***=E2=80=82[asm-offsets.s]=E2=80=82Error=E2=80=821 make[2]:=E2=80=82Leaving=E2=80=82directory=E2=80=82`/usr/src/packages/BUILD= /xen-unstable.hg-4.1.22571/xen/arch/x86' 36 static inline void atomic_write64(volatile uint64_t *addr, uint64_t val) 37 { 38 uint64_t old =3D *addr, new, *__addr =3D (uint64_t *)addr; 39 while ( (old =3D __cmpxchg8b(__addr, old, val)) !=3D old ) 40 old =3D new; 41 }