All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete
Date: Fri, 17 Dec 2010 09:16:33 -0500	[thread overview]
Message-ID: <20101217141633.GB30830@infradead.org> (raw)
In-Reply-To: <1292214743-18073-10-git-send-email-david@fromorbit.com>

On Mon, Dec 13, 2010 at 03:32:23PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> We now have two copies of AIL delete operations that are mostly
> duplicate functionality. The single log item deletes can be
> implemented via the bulk updates by turning xfs_trans_ail_delete()
> into a simple wrapper. This removes all the duplicate delete
> functionality and associated helpers.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

The same comment about just taking the address as for the previous patch
applies.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-12-17 14:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13  4:32 xfs: AIL lock contention reduction V3 Dave Chinner
2010-12-13  4:32 ` [PATCH 1/9] xfs: fix EFI transaction cancellation Dave Chinner
2010-12-17 11:18   ` Christoph Hellwig
2010-12-13  4:32 ` [PATCH 2/9] xfs: Pull EFI/EFD handling out from under the AIL lock Dave Chinner
2010-12-17 11:22   ` Christoph Hellwig
2010-12-20  1:00     ` Dave Chinner
2010-12-13  4:32 ` [PATCH 3/9] xfs: clean up xfs_ail_delete() Dave Chinner
2010-12-13  4:32 ` [PATCH 4/9] xfs: bulk AIL insertion during transaction commit Dave Chinner
2010-12-17 11:25   ` Christoph Hellwig
2010-12-13  4:32 ` [PATCH 5/9] xfs: reduce the number of AIL push wakeups Dave Chinner
2010-12-16 15:38   ` Christoph Hellwig
2010-12-16 21:50     ` Dave Chinner
2010-12-17  0:23       ` Christoph Hellwig
2010-12-13  4:32 ` [PATCH 6/9] xfs: consume iodone callback items on buffers as they are processed Dave Chinner
2010-12-13  4:32 ` [PATCH 7/9] xfs: remove all the inodes on a buffer from the AIL in bulk Dave Chinner
2010-12-17 11:25   ` Christoph Hellwig
2010-12-13  4:32 ` [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete Dave Chinner
2010-12-17 14:16   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101217141633.GB30830@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.