From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [Patch]Adding_threshold_support_to_coretemp
Date: Fri, 17 Dec 2010 22:26:36 +0000 [thread overview]
Message-ID: <20101217222636.GB13207@ericsson.com> (raw)
In-Reply-To: <D6D887BA8C9DFF48B5233887EF04654105C117387C@bgsmsx502.gar.corp.intel.com>
On Fri, Dec 17, 2010 at 02:59:34PM -0500, Guenter Roeck wrote:
> On Fri, Dec 17, 2010 at 01:17:09PM -0500, Fenghua Yu wrote:
> [ ... ]
> > > > temp1_max - All cooling devices should be turned on (on Core2).
> > > > + If the IA32_TEMPERATURE_TARGET is not supported, this
> > > > + value indicates the higher core threshold. When the CPU
> > > > + temperature crosses this temperature, an interrupt is
> > > > + generated.
> > The temp1_max explanation is confusing. This is not what your code is doing.
> > If both IA32_TEMPERATURE_TARGET and threshold are supported (most likely in
> > new processors), this explanation goes nowhere.
> >
> Then find a better text.
>
... such as:
temp1_max Temperature at which all cooling devices should be turned on.
Initialized with IA32_TEMPERATURE_TARGET if supported, otherwise
initialized with (tjmax - <pick something>).
When the CPU temperature reaches this temperature, an interrupt is
generated and temp1_max_alarm is set.
temp1_max_hyst If the CPU temperature falls below than this temperature, an interrupt
is generated and temp1_max_alarm is reset.
temp1_max_alarm Set if the temperature reaches or exceeds temp1_max. Reset if the temperature
drops to or below temp1_max_hyst.
This would extend the semantics of temp1_max, but not redefine it. Also, temp1_max_alarm
could conveniently be implemented such that it supports polling, and be used by an application
with poll() or select().
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-12-17 22:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 6:08 [lm-sensors] [Patch]Adding_threshold_support_to_coretemp R, Durgadoss
2010-12-17 17:15 ` Guenter Roeck
2010-12-17 17:52 ` R, Durgadoss
2010-12-17 18:17 ` Fenghua Yu
2010-12-17 18:28 ` Guenter Roeck
2010-12-17 19:59 ` Guenter Roeck
2010-12-17 21:56 ` Jean Delvare
2010-12-17 22:26 ` Guenter Roeck [this message]
2010-12-17 22:28 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2010-12-14 12:07 [lm-sensors] [Patch] Adding threshold support to coretemp R, Durgadoss
2010-12-14 18:24 ` Guenter Roeck
2010-12-14 18:24 ` Guenter Roeck
2010-12-15 12:29 ` R, Durgadoss
2010-12-15 12:41 ` R, Durgadoss
2010-12-15 15:10 ` Guenter Roeck
2010-12-15 15:10 ` Guenter Roeck
2010-12-16 10:48 ` R, Durgadoss
2010-12-16 10:50 ` R, Durgadoss
2010-12-16 14:59 ` Guenter Roeck
2010-12-16 14:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101217222636.GB13207@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.