From: Dan Carpenter <error27@gmail.com>
To: Russ Gorby <richardx.r.gorby@intel.com>
Cc: Alan Cox <alan@linux.intel.com>, linux-kernel@vger.kernel.org
Subject: smatch stuff: serial: ifx6x60: oops on load
Date: Mon, 20 Dec 2010 12:15:55 +0300 [thread overview]
Message-ID: <20101220091555.GR1936@bicker> (raw)
Smatch complains that the ifx6x60 driver in linux-next has a NULL
dereference.
drivers/serial/ifx6x60.c +986 ifx_spi_spi_probe(27)
error: potential null derefence 'pl_data'.
984 ifx_dev->spi_timer.function = ifx_spi_timeout;
985 ifx_dev->spi_timer.data = (unsigned long)ifx_dev;
986 ifx_dev->is_6160 = pl_data->is_6160;
^^^^^^^
"pl_data" is always NULL at this point. Presumably this crashes on load
every time.
regards,
dan carpenter
next reply other threads:[~2010-12-20 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 9:15 Dan Carpenter [this message]
2010-12-29 16:41 ` smatch stuff: serial: ifx6x60: oops on load Alan Cox
[not found] <4C5E6457CD7911469A07260381288C28CB379310@orsmsx502.amr.corp.intel.com>
[not found] ` <E1A1564674E5754FB00AB9AC949D5E3260EB004322@rrsmsx501.amr.corp.intel.com>
[not found] ` <72D8A09E39A89147BE9CFBB6F0C73C3061F523A532@rrsmsx501.amr.corp.intel.com>
[not found] ` <E1A1564674E5754FB00AB9AC949D5E3260EB09CDD7@rrsmsx501.amr.corp.intel.com>
2010-12-29 16:19 ` Gorby, Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220091555.GR1936@bicker \
--to=error27@gmail.com \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richardx.r.gorby@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.