From: "Ted Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-kernel@vger.kernel.org, sandeen@redhat.com
Subject: Re: [PATCH] ext4: fix possible overflow in ext4_trim_fs()
Date: Mon, 20 Dec 2010 07:35:21 -0500 [thread overview]
Message-ID: <20101220123521.GH23626@thunk.org> (raw)
In-Reply-To: <1290694277-29462-1-git-send-email-lczerner@redhat.com>
On Thu, Nov 25, 2010 at 03:11:17PM +0100, Lukas Czerner wrote:
> When determining last group through ext4_get_group_no_and_offset() the
> result may be wrong in cases when range->start and range-len are too
> big, because it may overflow when summing up those two numbers.
>
> Fix that by checking range->len and limit its value to
> ext4_blocks_count(). This commit was tested by myself with expected
> result.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Added to the ext4 patch queue. Thanks for the ping.
- Ted
next prev parent reply other threads:[~2010-12-20 12:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 14:11 [PATCH] ext4: fix possible overflow in ext4_trim_fs() Lukas Czerner
2010-12-20 10:30 ` Lukas Czerner
2010-12-20 12:35 ` Ted Ts'o [this message]
2011-01-10 11:25 ` Lukas Czerner
2011-01-10 11:28 ` Lukas Czerner
2011-01-10 16:35 ` Ted Ts'o
2011-01-10 16:52 ` Lukas Czerner
2011-01-10 17:04 ` Ted Ts'o
2011-01-10 19:50 ` Lukas Czerner
-- strict thread matches above, loose matches on Subject: below --
2010-11-25 15:53 Lukas Czerner
2011-01-03 11:02 ` Lukas Czerner
2011-01-03 11:09 ` Lukas Czerner
2011-09-05 14:34 Lukas Czerner
2011-09-06 4:15 ` Tao Ma
2011-09-06 6:26 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220123521.GH23626@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.