From: Stephen Hemminger <shemminger@vyatta.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: John Fastabend <john.r.fastabend@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org, hadi@cyberus.ca,
tgraf@infradead.org, eric.dumazet@gmail.com,
nhorman@tuxdriver.com
Subject: Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS
Date: Mon, 20 Dec 2010 14:58:44 -0800 [thread overview]
Message-ID: <20101220145844.35c4de44@nehalam> (raw)
In-Reply-To: <1292885287.3055.22.camel@bwh-desktop>
On Mon, 20 Dec 2010 22:48:07 +0000
Ben Hutchings <bhutchings@solarflare.com> wrote:
> > + u8 num_tc;
> > + struct netdev_tc_txq tc_to_txq[16];
> > + u8 prio_tc_map[16];
>
> That seems like a fair amount of data to add to every net device,
> considering that users may create e.g. a lot of VLAN devices and they
> won't use this state at all. Have you considered putting these in a
> structure that is accessed indirectly?
The tc stuff should use indirection and only allocate if needed.
--
next prev parent reply other threads:[~2010-12-20 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 16:56 [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS John Fastabend
2010-12-20 22:48 ` Ben Hutchings
2010-12-20 22:58 ` Stephen Hemminger [this message]
2010-12-20 22:58 ` Eric Dumazet
2010-12-21 19:15 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220145844.35c4de44@nehalam \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.