From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: [PATCH 07/12] Nested Virtualization: efer Date: Mon, 20 Dec 2010 17:08:06 +0100 Message-ID: <201012201708.07717.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_n93DN0OZj0dvOg0" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --Boundary-00=_n93DN0OZj0dvOg0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --Boundary-00=_n93DN0OZj0dvOg0 Content-Type: text/x-diff; charset="iso 8859-15"; name="xen_nh07_efer.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="xen_nh07_efer.diff" Content-Description: xen_nh07_efer.diff # HG changeset patch # User cegger # Date 1292839437 -3600 Allow guest to enable SVM in EFER Signed-off-by: Christoph Egger diff -r 2ec7ded683f7 -r 496c029072b1 xen/arch/x86/hvm/hvm.c --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -616,10 +616,15 @@ static int hvm_save_cpu_ctxt(struct doma return 0; } -static bool_t hvm_efer_valid(uint64_t value, uint64_t efer_validbits) +static bool_t hvm_efer_valid(struct domain *d, + uint64_t value, uint64_t efer_validbits) { + if ( nestedhvm_enabled(d) && cpu_has_svm ) + efer_validbits |= EFER_SVME; + return !((value & ~efer_validbits) || ((sizeof(long) != 8) && (value & EFER_LME)) || + (!cpu_has_svm && (value & EFER_SVME)) || (!cpu_has_nx && (value & EFER_NX)) || (!cpu_has_syscall && (value & EFER_SCE)) || (!cpu_has_lmsl && (value & EFER_LMSLE)) || @@ -634,6 +639,7 @@ static int hvm_load_cpu_ctxt(struct doma struct hvm_hw_cpu ctxt; struct segment_register seg; struct vcpu_guest_context *vc; + uint64_t efer_validbits; /* Which vcpu is this? */ vcpuid = hvm_load_instance(h); @@ -673,9 +679,9 @@ static int hvm_load_cpu_ctxt(struct doma return -EINVAL; } - if ( !hvm_efer_valid( - ctxt.msr_efer, - EFER_FFXSE | EFER_LMSLE | EFER_LME | EFER_LMA | EFER_NX | EFER_SCE) ) + efer_validbits = EFER_FFXSE | EFER_LMSLE | EFER_LME | EFER_LMA + | EFER_NX | EFER_SCE; + if ( !hvm_efer_valid(d, ctxt.msr_efer, efer_validbits) ) { gdprintk(XENLOG_ERR, "HVM restore: bad EFER 0x%"PRIx64"\n", ctxt.msr_efer); @@ -1214,14 +1220,15 @@ err: int hvm_set_efer(uint64_t value) { struct vcpu *v = current; + uint64_t efer_validbits; value &= ~EFER_LMA; - if ( !hvm_efer_valid(value, - EFER_FFXSE | EFER_LMSLE | EFER_LME | EFER_NX | EFER_SCE) ) + efer_validbits = EFER_FFXSE | EFER_LMSLE | EFER_LME | EFER_NX | EFER_SCE; + if ( !hvm_efer_valid(v->domain, value, efer_validbits) ) { gdprintk(XENLOG_WARNING, "Trying to set reserved bit in " - "EFER: %"PRIx64"\n", value); + "EFER: 0x%"PRIx64"\n", value); hvm_inject_exception(TRAP_gp_fault, 0, 0); return X86EMUL_EXCEPTION; } diff -r 2ec7ded683f7 -r 496c029072b1 xen/include/asm-x86/cpufeature.h --- a/xen/include/asm-x86/cpufeature.h +++ b/xen/include/asm-x86/cpufeature.h @@ -204,6 +204,8 @@ #define cpu_has_rdtscp boot_cpu_has(X86_FEATURE_RDTSCP) +#define cpu_has_svm boot_cpu_has(X86_FEATURE_SVME) + #endif /* __ASM_I386_CPUFEATURE_H */ /* --Boundary-00=_n93DN0OZj0dvOg0 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_n93DN0OZj0dvOg0--