From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Albert Astals Cid <aacid@kde.org>
Cc: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: Patch for drivers/platform/x86/compal-laptop.c
Date: Mon, 20 Dec 2010 22:51:45 +0000 [thread overview]
Message-ID: <20101220225145.GA2488@srcf.ucam.org> (raw)
In-Reply-To: <201012202249.36307.aacid@kde.org>
On Mon, Dec 20, 2010 at 10:49:35PM +0000, Albert Astals Cid wrote:
> A Dilluns, 20 de desembre de 2010, Matthew Garrett va escriure:
> > Patch looks fine, but could you submit it following the instructions in
> > Documentation/SubmittingPatches? I'll need a signed-off-by: line at
> > least.
>
> To be fair i don't know which subsystem this belongs to.
It's the x86 platform drivers. There's not really a terribly good way to
express that in a subject line :)
> I guess my summary phrase would be:
> Support KHLB2 in the compal laptop driver
>
> The explanation would be:
> Add the KHLB2 model identifier to the list of supported models
>
> Signed-off-by: Albert Astals Cid <aacid@kde.org>
That ought to be ok. In future it's easier if you include the patch as
part of the mail - git send-email is really the most straightforward way
to generate correct patches.
Thanks,
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-12-20 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 20:09 Patch for drivers/platform/x86/compal-laptop.c Albert Astals Cid
2010-12-20 16:11 ` Matthew Garrett
2010-12-20 22:49 ` Albert Astals Cid
2010-12-20 22:51 ` Matthew Garrett [this message]
2011-01-07 22:30 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220225145.GA2488@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=aacid@kde.org \
--cc=cezary.jackiewicz@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.