Re: [PATCH 1/2] mmc: agressive clocking framework v8

[Chris Ball <cjb@laptop.org>]

Hi Linus,

On Wed, Nov 03, 2010 at 10:22:50AM +0100, Linus Walleij wrote:
> +/*
> + *	mmc_host_clk_exit - shut down clock gating code
> + *	@host: host with potential clock to control
> + */
> +static inline void mmc_host_clk_exit(struct mmc_host *host)
> +{
> +	/*
> +	 * Wait for any outstanding gate and then make sure we're
> +	 * ungated before exiting.
> +	 */
> +	if (cancel_work_sync(&host->clk_disable_work))
> +		mmc_host_clk_gate_delayed(host);
> +	if (host->clk_gated)
> +		mmc_host_clk_ungate(host);
> +	BUG_ON(host->clk_requests > 0);
> +}

I just hit the BUG_ON() above, when doing "rmmod sdhci-pci" on my x86
laptop running today's linux-next.  There was *no* SD card inserted,
and hadn't been one inserted all boot.

Let me know if you want me to try adding any extra debugging/patches.

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child