From: Tony Lindgren <tony@atomide.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Adrian Hunter <adrian.hunter@nokia.com>,
Manjunath Kondaiah G <manjugk@ti.com>,
linux-omap Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] OMAP: DMA: clear interrupt status correctly
Date: Tue, 21 Dec 2010 12:29:14 -0800 [thread overview]
Message-ID: <20101221202914.GK5829@atomide.com> (raw)
In-Reply-To: <541b3a50479779f3e814aa93d506cbdd@mail.gmail.com>
* Santosh Shilimkar <santosh.shilimkar@ti.com> [101130 06:15]:
> > -----Original Message-----
> > From: Adrian Hunter [mailto:adrian.hunter@nokia.com]
> > Sent: Tuesday, November 30, 2010 6:54 PM
> > To: Tony Lindgren
> > Cc: Santosh Shilimkar; Manjunatha GK; Adrian Hunter; linux-omap Mailing
> > List
> > Subject: [PATCH 2/2] OMAP: DMA: clear interrupt status correctly
> >
> > From 85934ded48552fde84b083575ac2006f1542324b Mon Sep 17 00:00:00 2001
> > From: Adrian Hunter <adrian.hunter@nokia.com>
> > Date: Wed, 24 Nov 2010 13:23:21 +0200
> > Subject: [PATCH 2/2] OMAP: DMA: clear interrupt status correctly
> >
> > When clearing the DMA channel, clear all status bits.
> >
> > When handling a DMA interrupt, clear only the interrupt
> > status bits that have been read and are passed to the
> > channel's interrupt handler, not every status bit.
> >
> > Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Adrian, care to refresh this one against the devel-dma
branch that has the hwmod changes?
Looks like at least the CSR_CLEAR_MASK is still wrong
in the current code.
Regards,
Tony
next prev parent reply other threads:[~2010-12-21 20:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 13:23 [PATCH 0/2] Minor DMA fixes Adrian Hunter
2010-11-30 13:23 ` [PATCH 1/2] OMAP: DMA: prevent races while setting M idle mode to nostandby Adrian Hunter
2010-11-30 14:24 ` Santosh Shilimkar
2010-12-01 12:21 ` Peter Ujfalusi
2010-12-01 19:11 ` G, Manjunath Kondaiah
2010-11-30 13:23 ` [PATCH 2/2] OMAP: DMA: clear interrupt status correctly Adrian Hunter
2010-11-30 14:25 ` Santosh Shilimkar
2010-12-21 20:29 ` Tony Lindgren [this message]
2011-01-05 9:58 ` Adrian Hunter
2011-01-05 17:27 ` Kevin Hilman
2011-01-19 10:24 ` [PATCH] " Adrian Hunter
2011-01-19 10:24 ` Adrian Hunter
2011-01-19 22:23 ` Tony Lindgren
2011-01-19 22:23 ` Tony Lindgren
2011-01-19 22:44 ` Tony Lindgren
2011-01-19 22:44 ` Tony Lindgren
2011-01-20 3:44 ` G, Manjunath Kondaiah
2011-01-20 3:44 ` G, Manjunath Kondaiah
2011-01-20 11:10 ` Adrian Hunter
2011-01-20 11:10 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221202914.GK5829@atomide.com \
--to=tony@atomide.com \
--cc=adrian.hunter@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.