Re: [PATCH 2/3] sdhci: don't finish commands in flight

[Chris Ball <cjb@laptop.org>]

Hi Olof,

On Wed, Dec 22, 2010 at 02:01:10AM -0600, Olof Johansson wrote:
> Don't schedule the finish_tasklet unless the command complete bit is
> set in the interrupt status register.
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>

Could we have some more detail here, please?  What are the symptoms of
running without this patch?  Should we apply it to the stable tree too?

> ---
>  drivers/mmc/host/sdhci.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index c0094c1..562aaea 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1432,7 +1432,8 @@ static void sdhci_cmd_irq(struct sdhci_host *host, u32 intmask)
>  		host->cmd->error = -EILSEQ;
>  
>  	if (host->cmd->error) {
> -		tasklet_schedule(&host->finish_tasklet);
> +		if (intmask & SDHCI_INT_RESPONSE)
> +			tasklet_schedule(&host->finish_tasklet);
>  		return;
>  	}
>  

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child