From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH -tip 2/4] [BUGFIX]perf: Fix strlist__parse_list to handle const string
Date: Wed, 22 Dec 2010 12:32:58 -0200 [thread overview]
Message-ID: <20101222143258.GA32740@ghostprotocols.net> (raw)
In-Reply-To: <4D118543.3040007@hitachi.com>
Em Wed, Dec 22, 2010 at 01:57:39PM +0900, Masami Hiramatsu escreveu:
> (2010/12/22 3:23), Arnaldo Carvalho de Melo wrote:
> > Em Fri, Dec 17, 2010 at 10:12:06PM +0900, Masami Hiramatsu escreveu:
> > Wouldn't be better to just stop changing the string by passing the
> > length to strlist__parse_list_entry, etc?
>
> Yeah, it could be, but in that case, we need changing code
> wider.
> I think this is the simplest solution. :)
Ok, I'll try to fix it as I suggested, it it turns out difficult I'll
apply the minimal fix.
> (Of course, we have to check dupstr flag on top of strlist__load too.)
>
> Thank you,
You're welcome,
- Arnaldo
next prev parent reply other threads:[~2010-12-22 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 13:11 [PATCH -tip 0/4][BUGFIX] Perf probe bugfixes Masami Hiramatsu
2010-12-17 13:12 ` [PATCH -tip 1/4] [BUGFIX]perf: Fix lazy wildcard matching Masami Hiramatsu
2010-12-22 11:32 ` [tip:perf/urgent] perf tools: " tip-bot for Masami Hiramatsu
2010-12-17 13:12 ` [PATCH -tip 2/4] [BUGFIX]perf: Fix strlist__parse_list to handle const string Masami Hiramatsu
2010-12-21 18:23 ` Arnaldo Carvalho de Melo
2010-12-22 4:57 ` Masami Hiramatsu
2010-12-22 14:32 ` Arnaldo Carvalho de Melo [this message]
2010-12-17 13:12 ` [PATCH -tip 3/4] [CLEANUP]perf probe: cleanup messages Masami Hiramatsu
2010-12-22 11:30 ` [tip:perf/core] perf probe: Cleanup messages tip-bot for Masami Hiramatsu
2010-12-17 13:12 ` [PATCH -tip 4/4] [BUGFIX]perf probe: Fix to support libdwfl older than 0.148 Masami Hiramatsu
2010-12-22 11:32 ` [tip:perf/urgent] perf " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222143258.GA32740@ghostprotocols.net \
--to=acme@infradead.org \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.