From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfs: remove leftovers of old buffer log items in recovery code
Date: Thu, 23 Dec 2010 12:50:40 +1100 [thread overview]
Message-ID: <20101223015040.GA18264@dastard> (raw)
In-Reply-To: <20101201220710.042656730@bombadil.infradead.org>
On Wed, Dec 01, 2010 at 05:06:21PM -0500, Christoph Hellwig wrote:
> XFS used to support different types of buffer log items long time ago.
> Remove the switch statements checking the log item type in various
> buffer recovery helpers that were left over from those days and the
> rather useless xlog_recover_do_buffer_pass2 wrapper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. This should have been done when all the old unsupported
buffer formats were removed.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-23 1:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 22:06 [PATCH 0/4] log recovery cleanups Christoph Hellwig
2010-12-01 22:06 ` [PATCH 1/4] xfs: remove leftovers of old buffer log items in recovery code Christoph Hellwig
2010-12-23 1:50 ` Dave Chinner [this message]
2010-12-01 22:06 ` [PATCH 2/4] xfs: use struct list_head for the buf cancel table Christoph Hellwig
2010-12-23 1:54 ` Dave Chinner
2010-12-01 22:06 ` [PATCH 3/4] xfs: refactor xlog_recover_commit_trans Christoph Hellwig
2010-12-16 21:18 ` Alex Elder
2010-12-20 11:28 ` Christoph Hellwig
2010-12-23 1:56 ` Dave Chinner
2010-12-01 22:06 ` [PATCH 4/4] xfs: untangle phase1 vs phase2 recovery helpers Christoph Hellwig
2010-12-23 2:06 ` Dave Chinner
2010-12-16 21:14 ` [PATCH 0/4] log recovery cleanups Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223015040.GA18264@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.