From: Senthil Balasubramanian <senthilkumar@atheros.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Stable Kernel <stable@kernel.org>
Subject: Re: [PATCH v3 1/2] ath9k_hw: Fix incorrect macversion and macrev checks
Date: Thu, 23 Dec 2010 07:25:42 +0530 [thread overview]
Message-ID: <20101223015542.GA4215@senthil-lnx.users.atheros.com> (raw)
In-Reply-To: <AANLkTikGgSbAY1FRHNOoVmgVk3BKdvBtY+ir9y5BywW0@mail.gmail.com>
On Wed, Dec 22, 2010 at 09:22:06PM +0530, Luis R. Rodriguez wrote:
> On Wed, Dec 22, 2010 at 10:44 AM, Senthil Balasubramanian
> <senthilkumar@atheros.com> wrote:
> > There are few places where we are checking for macversion and revsions
> > before RTC is powered ON. However we are reading the macversion and
> > revisions only after RTC is powered ON and so both macversion and
> > revisions are actully zero and this leads to incorrect srev checks
> >
> > Incorrect srev checks can cause registers to be configured wrongly and can
> > cause unexpected behavior. Fixing this seems to address the ASPM issue that
> > we have observed. The laptop becomes very slow and hangs mostly with ASPM L1
> > enabled without this fix.
>
> On what chipset? Or did we see this on one chipset and suspect it can
> affect others?
We have noticed on Merlin and it is obviously incorrect for other chipsets
also :-(. Please feel free to rephrase/rework on this patch if you think
something is still lacking/missing...
>
> Luis
next prev parent reply other threads:[~2010-12-23 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 15:44 [PATCH v3 1/2] ath9k_hw: Fix incorrect macversion and macrev checks Senthil Balasubramanian
2010-12-22 15:52 ` Luis R. Rodriguez
2010-12-23 1:55 ` Senthil Balasubramanian [this message]
2010-12-23 2:04 ` Senthil Balasubramanian
2010-12-23 2:07 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223015542.GA4215@senthil-lnx.users.atheros.com \
--to=senthilkumar@atheros.com \
--cc=Senthilkumar.Balasubramanian@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.