From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 2/2] spi_imx.c: TRIVIAL mx25 & mx35 SPI_VER is 0.7
Date: Thu, 23 Dec 2010 12:03:15 -0700
Message-ID: <20101223190315.GD20384@angua.secretlab.ca>
References: <1293102730-32528-1-git-send-email-richard.genoud@gmail.com>
 <1293102730-32528-2-git-send-email-richard.genoud@gmail.com>
 <20101223142934.GU14221@pengutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Richard Genoud <richard.genoud@gmail.com>,
	spi-devel-general@lists.sourceforge.net,
	David Brownell <dbrownell@users.sourceforge.net>,
	linux-kernel@vger.kernel.org
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=
	<u.kleine-koenig@pengutronix.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20101223142934.GU14221@pengutronix.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-spi.vger.kernel.org

On Thu, Dec 23, 2010 at 03:29:34PM +0100, Uwe Kleine-K=F6nig wrote:
> On Thu, Dec 23, 2010 at 12:12:10PM +0100, Richard Genoud wrote:
> > The check on cpu_is_mx25 and cpu_is_mx35 was made twice.
> > This is obviously wrong.
> obviously wrong but no wrong behaviour.  Your patch only makes the co=
de
> consistent, but IMHO it doesn't qualify as a bugfix.
>=20
> > Anyway, this patch won't change the previous behaviour which is
> > SPI_IMX_VER_0_7 for mx25 and mx35.
> This conflicts with
> http://mid.gmane.org/1290589546-21662-1-git-send-email-u.kleine-koeni=
g@pengutronix.de
>=20
> which I prefer.  The platform IDs have it correct (i.e.
>=20
> 	imx25-cspi -> 0.7
> 	imx31-cspi -> 0.4
> 	imx35-cspi -> 0.7
>=20
> )

Oops, missed you're reply.  Okay, I've dropped Richard's patch and will=
 look at yours.


g.