From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH 0/8] Address recent SCST comments
Date: Mon, 27 Dec 2010 14:35:33 +0100
Message-ID: <201012271435.33778.bvanassche@acm.org>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-scsi-owner@vger.kernel.org>
Received: from jester.euphonynet.be ([212.87.96.13]:51584 "EHLO
	mailpush2.euphonynet.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753505Ab0L0Nfn (ORCPT
	<rfc822;linux-scsi@vger.kernel.org>); Mon, 27 Dec 2010 08:35:43 -0500
Sender: linux-scsi-owner@vger.kernel.org
List-Id: linux-scsi@vger.kernel.org
To: linux-scsi@vger.kernel.org
Cc: scst-devel@lists.sourceforge.net, Greg Kroah-Hartman <gregkh@suse.de>, Konrad Rzeszutek Wilk <konrad@darnok.org>, Vladislav Bolkhovitin <vst@vlnb.net>, Richard Sharpe <realrichardsharpe@gmail.com>

The paches in this patch series address the following issues:
- Make sure that all SCST sysfs attributes have only one value per file.
- Remove the '[key]' marker from sysfs files since it is nonstandard.
- Replace the symbolic constant SCST_SYSFS_BLOCK_SIZE by PAGE_SIZE.
- Improved the robustness of the sysfs parsing code.
- Fixed the errors in the online documentation of /sys/devices/scst/mgmt.
- Correct the version number of the SCST core.
- Update the documentation in Documentation/ABI/stable according to the above
  changes.
- Made the SCST sysfs documentation more clear. All comments formulated by Greg
  and Konrad about the documentation in Documentation/ABI/stable should have been
  addressed.

Notes:
- In case anyone starts wondering why set commands were introduced instead of
  making sysfs files writeable: the reason behind this is to avoid lock inversion.
- While examining how SCST has been configured via the sysfs interface is
  straightforward, configuring SCST via sysfs can be tedious. There exists a
  user space tool that allows to save a configuration to disk and to restore
  a configuration, even without restarting SCST. The source code of that tool
  can be obtained as follows:

  svn co https://scst.svn.sourceforge.net/svnroot/scst/branches/sysfs-tree-changes/scstadmin

  An example of a configuration file generated by the scstadmin tool:

# Automatically generated by SCST Configurator v2.0.0.


HANDLER vdisk_fileio {
	DEVICE disk01 {
		filename /dev/vdisk1
		nv_cache 1
	}
	DEVICE disk02 {
		filename /dev/vdisk2
		nv_cache 1
	}
	DEVICE disk03 {
		filename /dev/vdisk3
		nv_cache 1
	}
	DEVICE disk04 {
		filename /dev/vdisk4
		nv_cache 1
	}
}

HANDLER vdisk_nullio {
	DEVICE disk05
	DEVICE disk06
	DEVICE disk07
}

TARGET_DRIVER ib_srpt {
	TARGET ib_srpt_target_0 {
		rel_tgt_id 1
		enabled 1

		LUN 0 disk01
		LUN 1 disk02
		LUN 2 disk03
		LUN 3 disk04
		LUN 4 disk05
		LUN 5 disk06
		
		GROUP initiator1 {
			INITIATOR 0x00000000000000000002c9030005f34b
			INITIATOR 0x00000000000000000002c9030005f34c
			LUN 0 disk01
			LUN 1 disk02
			LUN 2 disk03
			LUN 3 disk04
			LUN 4 disk05
			LUN 5 disk06
			LUN 6 disk07
		}
	}

	TARGET ib_srpt_target_1 {
		rel_tgt_id 2
		enabled 1

		LUN 0 disk01
		LUN 1 disk02
		LUN 2 disk03
		LUN 3 disk04
		LUN 4 disk05
		LUN 5 disk06
	}
}