From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39091 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PXKdB-0007yd-F1
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 16:29:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PXKdA-0005Ks-2y
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 16:29:25 -0500
Received: from hall.aurel32.net ([88.191.126.93]:60635)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PXKd9-0005K4-SF
	for qemu-devel@nongnu.org; Mon, 27 Dec 2010 16:29:23 -0500
Date: Mon, 27 Dec 2010 22:03:44 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] x86: Filter out garbage from segment
	flags dump
Message-ID: <20101227210344.GF4098@volta.aurel32.net>
References: <4D18A828.2040801@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4D18A828.2040801@web.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Mon, Dec 27, 2010 at 03:52:24PM +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Only bits 8..23 of the segment flags contain valid data, so only dump
> those when printing the CPU state.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  target-i386/helper.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.

> diff --git a/target-i386/helper.c b/target-i386/helper.c
> index 26ea1e5..25a3e36 100644
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -175,12 +175,12 @@ cpu_x86_dump_seg_cache(CPUState *env, FILE *f, fprintf_function cpu_fprintf,
>  #ifdef TARGET_X86_64
>      if (env->hflags & HF_CS64_MASK) {
>          cpu_fprintf(f, "%-3s=%04x %016" PRIx64 " %08x %08x", name,
> -                    sc->selector, sc->base, sc->limit, sc->flags);
> +                    sc->selector, sc->base, sc->limit, sc->flags & 0x00ffff00);
>      } else
>  #endif
>      {
>          cpu_fprintf(f, "%-3s=%04x %08x %08x %08x", name, sc->selector,
> -                    (uint32_t)sc->base, sc->limit, sc->flags);
> +                    (uint32_t)sc->base, sc->limit, sc->flags & 0x00ffff00);
>      }
>  
>      if (!(env->hflags & HF_PE_MASK) || !(sc->flags & DESC_P_MASK))
> -- 
> 1.7.1
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net