Re: [uClinux-dev] [PATCH] m68knommu: Coldfire QSPI platform support

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Fri, Dec 10, 2010 at 08:46:35AM -0800, Steven King wrote:
> On Wednesday 29 September 2010 06:44:32 Jate Sujjavanich wrote:
> > Here's a patch for your review.
> >
> >
> > After grabbing a msg from the msgq, the mcfqspi_work function calls
> > list_del_init on the mcfqspi->msgq which unintentionally deletes the rest
> > of the list before it can be processed. If qspi call was made using
> > spi_sync, this can result in a process hang.
> >
> > Signed-off by Jate Sujjavanich<jsujjavanich-oI4RZb1+6EReLsYL91UIxL5dPsmED6B0@public.gmane.org>
> > -----------
> > diff --git a/drivers/spi/coldfire_qspi.c b/drivers/spi/coldfire_qspi.c
> > index 59be3ef..0aa00af 100644
> > --- a/drivers/spi/coldfire_qspi.c
> > +++ b/drivers/spi/coldfire_qspi.c
> > @@ -316,7 +316,7 @@ static void mcfqspi_work(struct work_struct *work)
> >                  msg = container_of(mcfqspi->msgq.next, struct spi_message,
> >                                     queue);
> > -               list_del_init(&mcfqspi->msgq);
> > +               list_del_init(&msg->queue);
> >                  spin_unlock_irqrestore(&mcfqspi->lock, flags);
> >                  spi = msg->spi;
> >
> 
> 
> A belated ack.
> 
> Grant, can we still get this into .37?

Applied manually (patch was mailer-damaged).  I'll see if Linux will still pick it up for .37.

thanks.
g.

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl