From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PYC1G-0005nJ-9U for mharc-grub-devel@gnu.org; Thu, 30 Dec 2010 01:29:50 -0500 Received: from [140.186.70.92] (port=53525 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PYC1C-0005n6-U9 for grub-devel@gnu.org; Thu, 30 Dec 2010 01:29:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PYC1B-0006OR-DC for grub-devel@gnu.org; Thu, 30 Dec 2010 01:29:46 -0500 Received: from 207-172-210-101.c3-0.hdp-ubr1.sbo-hdp.ma.static.cable.rcn.com ([207.172.210.101]:50204 helo=mailhost.m5p.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PYC1B-0006OF-3k for grub-devel@gnu.org; Thu, 30 Dec 2010 01:29:45 -0500 Received: from m5p.com (ssh.m5p.com [IPv6:2001:418:3fd::fb]) by mailhost.m5p.com (8.14.3/8.14.3) with ESMTP id oBU6TcYD021031 for ; Thu, 30 Dec 2010 01:29:44 -0500 (EST) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.14.4/8.13.7/Submit) id oBU6TcSp022378 for grub-devel@gnu.org; Wed, 29 Dec 2010 22:29:38 -0800 (PST) Message-Id: <201012300629.oBU6TcSp022378@m5p.com> To: grub-devel@gnu.org Date: Wed, 29 Dec 2010 22:29:38 -0800 (PST) Sender: ehem@m5p.com From: ehem+grub@m5p.com X-Mailer: ELM [version 2.4ME+ PL124d (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" X-Scanned-By: MIMEDefang 2.67 on IPv6:2001:418:3fd::f7 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (mailhost.m5p.com [IPv6:2001:418:3fd::f7]); Thu, 30 Dec 2010 01:29:44 -0500 (EST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Subject: Small Bug in grub-core/partmap/amiga.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2010 06:29:47 -0000 Alas, AmigaOS has mostly passed beyond the veil, but one can still find small bugs sometimes: === modified file 'grub-core/partmap/amiga.c' --- grub-core/partmap/amiga.c 2010-03-26 14:44:13 +0000 +++ grub-core/partmap/amiga.c 2010-12-30 06:25:26 +0000 @@ -87,7 +87,7 @@ if (grub_disk_read (disk, pos, 0, sizeof (rdsk), &rdsk)) return grub_errno; - if (grub_strcmp ((char *) rdsk.magic, "RDSK") == 0) + if (grub_strncmp ((char *) rdsk.magic, "RDSK", sizeof(rdsk.magic)) == 0) { /* Found the first PART block. */ next = grub_be_to_cpu32 (rdsk.partitionlst); I both like and dislike using strcmp() for this purpose. I kind of like keeping it as a string, but strcmp()... Anyway, minimal solution. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | EHeM@gremlin.m5p.com PGP F6B23DE0 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 2477\___\_|_/DC21 03A0 5D61 985B <-PGP-> F2BE 6526 ABD2 F6B2\_|_/___/3DE0