From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 4/4] drm/i915: add PLL enable/disable
 functions
Date: Thu, 30 Dec 2010 13:47:52 -0800
Message-ID: <20101230134752.47bbd5c7@jbarnes-desktop>
References: <1293743792-8665-1-git-send-email-jbarnes@virtuousgeek.org>
	<1293743792-8665-5-git-send-email-jbarnes@virtuousgeek.org>
	<849307$av59ci@azsmga001.ch.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy2-pub.bluehost.com (oproxy2-pub.bluehost.com
	[67.222.39.60])
	by gabe.freedesktop.org (Postfix) with SMTP id C14E29E732
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 30 Dec 2010 13:47:54 -0800 (PST)
In-Reply-To: <849307$av59ci@azsmga001.ch.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 30 Dec 2010 21:41:18 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Thu, 30 Dec 2010 13:16:32 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> >  /**
> > + * intel_enable_pll - enable a PLL
> > + * @dev_priv: i915 private structure
> > + * @pipe: pipe PLL to enable
> > + *
> > + * Enable @pipe's PLL so we can start pumping pixels from a plane.  Check to
> > + * make sure the PLL reg is writable first though, since the panel write
> > + * protect mechanism may be enabled.
> > + *
> > + * Note!  This is for pre-ILK only.
> > + */
> > +static void intel_enable_pll(struct drm_i915_private *dev_priv, enum pipe pipe)
> > +{
> > +	int reg;
> > +	u32 val;
> 
> Reinforce the comments with a BUG_ON(dev_priv->info->gen >= 5);

Ah good call.  Fixed.  Also moved the "don't disable" quirks check into
the proper function (the disable one!).

-- 
Jesse Barnes, Intel Open Source Technology Center