From: richard.zhao@freescale.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/8] ARM: mx5: use config to define boot related addresses
Date: Fri, 31 Dec 2010 10:48:05 +0800 [thread overview]
Message-ID: <20101231024805.GA17804@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <20101231020156.GG28246@freescale.com>
Hello Uwe,
On Fri, Dec 31, 2010 at 10:01:57AM +0800, Shawn Guo wrote:
> Hi Uwe,
>
> On Thu, Dec 30, 2010 at 12:05:06PM +0100, Uwe Kleine-K?nig wrote:
> > Hello Richard,
> >
> > On Thu, Dec 30, 2010 at 07:00:26PM +0800, Richard Zhao wrote:
> > > On Thu, Dec 30, 2010 at 10:31:27AM +0100, Uwe Kleine-K?nig wrote:
> > > > On Thu, Dec 30, 2010 at 12:56:02PM +0800, Richard Zhao wrote:
> > > > > Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
> > > > > ---
> > > > > Because common clock is changing, I don't send out mx50 clock code.
> > > > > But sure I tested the patch series using the clock code.
> > > > >
> > > > > arch/arm/mach-mx5/Makefile.boot | 6 +++---
> > > > > 1 files changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/arch/arm/mach-mx5/Makefile.boot b/arch/arm/mach-mx5/Makefile.boot
> > > > > index 9939a19..fec7cd9 100644
> > > > > --- a/arch/arm/mach-mx5/Makefile.boot
> > > > > +++ b/arch/arm/mach-mx5/Makefile.boot
> > > > > @@ -1,3 +1,3 @@
> > > > > - zreladdr-y := 0x90008000
> > > > > -params_phys-y := 0x90000100
> > > > > -initrd_phys-y := 0x90800000
> > > > > + zreladdr-$(CONFIG_ARCH_MX51) := 0x90008000
> > > > > +params_phys-$(CONFIG_ARCH_MX51) := 0x90000100
> > > > > +initrd_phys-$(CONFIG_ARCH_MX51) := 0x90800000
> > > > looks good
> > > >
> > > > Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > > Thanks.
> > > For such patch acked, do I need to re-send it out when I send out v4 version
> > > of the patch series?
> > As I'm not the imx-maintainer, I'd say yes, send it out (with my ack
> > added) in v4.
> >
> Richard was trying to understand the correct approach for sending
> patch series.
>
> I used to only send the updated patches in the new patch series
> since the last series version, while Richard prefer to send all
> the patches in the very single version, even most of them are not
> changed since the last version.
>
> I think the sending delta way could save bandwidth and ease reviewing
> a little bit, while sending all may be easy for people to pick up
> the patches. So what is the preference for you guys?
yes, it's kind of what I'd ask. If I had v5 version, do I need to send out this
patch with V5 header and your ack too? V4 patch already has your ack.
Either way is Ok for me. Just consider which way help maintainer review and merge patch.
Thanks
Richard
>
> > Uwe
> >
> > --
> > Pengutronix e.K. | Uwe Kleine-K?nig |
> > Industrial Linux Solutions | http://www.pengutronix.de/ |
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
> --
> Regards,
> Shawn
next prev parent reply other threads:[~2010-12-31 2:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 4:56 [PATCH v3 1/8] ARM: mx5: use config to define boot related addresses Richard Zhao
2010-12-30 4:56 ` [PATCH v3 2/8] arm: plat-mxc: add full parameter macro to define gpio port Richard Zhao
2010-12-30 4:56 ` [PATCH v3 3/8] arm: mx51: define mx51's own MXC_GPIO_IRQS Richard Zhao
2010-12-30 4:56 ` [PATCH v3 4/8] arm: mx5: mx51/53 have different mxc_cpu_type definition Richard Zhao
2010-12-30 4:56 ` [PATCH v3 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h Richard Zhao
2010-12-30 4:56 ` [PATCH v3 6/8] arm: mx50: add core functions support except clock Richard Zhao
2010-12-30 4:56 ` [PATCH v3 7/8] arm: mx50: add mx50 reference design board support Richard Zhao
2010-12-30 9:46 ` Uwe Kleine-König
2010-12-30 10:55 ` Richard Zhao
2010-12-30 9:29 ` [PATCH v3 6/8] arm: mx50: add core functions support except clock Richard Zhao
2010-12-30 9:40 ` Uwe Kleine-König
2010-12-30 10:40 ` Richard Zhao
2010-12-30 9:33 ` [PATCH v3 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h Uwe Kleine-König
2010-12-30 9:33 ` [PATCH v3 4/8] arm: mx5: mx51/53 have different mxc_cpu_type definition Uwe Kleine-König
2010-12-30 9:32 ` [PATCH v3 3/8] arm: mx51: define mx51's own MXC_GPIO_IRQS Uwe Kleine-König
2010-12-30 9:31 ` [PATCH v3 2/8] arm: plat-mxc: add full parameter macro to define gpio port Uwe Kleine-König
2010-12-30 9:31 ` [PATCH v3 1/8] ARM: mx5: use config to define boot related addresses Uwe Kleine-König
2010-12-30 11:00 ` Richard Zhao
2010-12-30 11:05 ` Uwe Kleine-König
2010-12-31 2:01 ` Shawn Guo
2010-12-31 2:48 ` Richard Zhao [this message]
2010-12-31 16:23 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231024805.GA17804@shlinux1.ap.freescale.net \
--to=richard.zhao@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.