diff for duplicates of <20101231113949.GA21179@mail.oracle.com> diff --git a/a/1.txt b/N1/1.txt index 7628915..2562944 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,7 +8,7 @@ On Fri, Dec 31, 2010 at 10:16:35PM +1100, Nick Piggin wrote: > >> business end of your handler, you want to hold the page locked, after > >> you verify it is correct, and return that to the fault handler. > > -> > This is going to be hard. Our write_end() assumes it must +> > ? ? ? ?This is going to be hard. ?Our write_end() assumes it must > > unlock the pages (which is normal behavior for write(2)), but in the > > page_mkwrite() case we need to avoid the unlock to follow your > > recommendation (we use our write_begin/write_end pair to trigger any @@ -26,8 +26,8 @@ On Fri, Dec 31, 2010 at 10:16:35PM +1100, Nick Piggin wrote: want us to get there, or are minor faults in the old-0-style OK?" question. -> > The find_or_create_page() is deep at the meat of the function, -> > not the cursory check at the top. The idea is that at this point, +> > ? ? ? ?The find_or_create_page() is deep at the meat of the function, +> > not the cursory check at the top. ?The idea is that at this point, > > find_or_create_page() will return a locked page that must, by > > definition, be part of the correct mapping. > @@ -40,7 +40,7 @@ restart. Though cleanup should be the same; I'm looking at our code trying to convince myself that this is so ;-) Btw, -ENOMEM is that OOM fault error, right? ;-) -> > If the VM is rechecking the pte after we return from +> > ? ? ? ?If the VM is rechecking the pte after we return from > > page_mkwrite(), won't it see any new page created? > > But the point of page_mkwrite is a dirty notifier for the fs. If this new @@ -69,9 +69,5 @@ Joel Joel Becker Senior Development Manager Oracle -E-mail: joel.becker@oracle.com +E-mail: joel.becker at oracle.com Phone: (650) 506-8127 --- -To unsubscribe from this list: send the line "unsubscribe linux-ext4" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 8636364..dd21107 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020101231110054.GA20521@mail.oracle.com\0" "ref\0AANLkTik3_=Jo2ubML1hhanFFKC3MkEibrCPruto2oY_v@mail.gmail.com\0" "From\0Joel Becker <Joel.Becker@oracle.com>\0" - "Subject\0Re: Confused by commit 56a76f [fs: fix page_mkwrite error cases in core code and btrfs]\0" + "Subject\0[Ocfs2-devel] Confused by commit 56a76f [fs: fix page_mkwrite error cases in core code and btrfs]\0" "Date\0Fri, 31 Dec 2010 03:39:50 -0800\0" "To\0Nick Piggin <npiggin@gmail.com>\0" "Cc\0linux-fsdevel@vger.kernel.org" @@ -21,7 +21,7 @@ "> >> business end of your handler, you want to hold the page locked, after\n" "> >> you verify it is correct, and return that to the fault handler.\n" "> >\n" - "> > \302\240 \302\240 \302\240 \302\240This is going to be hard. \302\240Our write_end() assumes it must\n" + "> > ? ? ? ?This is going to be hard. ?Our write_end() assumes it must\n" "> > unlock the pages (which is normal behavior for write(2)), but in the\n" "> > page_mkwrite() case we need to avoid the unlock to follow your\n" "> > recommendation (we use our write_begin/write_end pair to trigger any\n" @@ -39,8 +39,8 @@ "want us to get there, or are minor faults in the old-0-style OK?\"\n" "question.\n" " \n" - "> > \302\240 \302\240 \302\240 \302\240The find_or_create_page() is deep at the meat of the function,\n" - "> > not the cursory check at the top. \302\240The idea is that at this point,\n" + "> > ? ? ? ?The find_or_create_page() is deep at the meat of the function,\n" + "> > not the cursory check at the top. ?The idea is that at this point,\n" "> > find_or_create_page() will return a locked page that must, by\n" "> > definition, be part of the correct mapping.\n" "> \n" @@ -53,7 +53,7 @@ "trying to convince myself that this is so ;-) Btw, -ENOMEM is that OOM\n" "fault error, right? ;-)\n" "\n" - "> > \302\240 \302\240 \302\240 \302\240If the VM is rechecking the pte after we return from\n" + "> > ? ? ? ?If the VM is rechecking the pte after we return from\n" "> > page_mkwrite(), won't it see any new page created?\n" "> \n" "> But the point of page_mkwrite is a dirty notifier for the fs. If this new\n" @@ -82,11 +82,7 @@ "Joel Becker\n" "Senior Development Manager\n" "Oracle\n" - "E-mail: joel.becker@oracle.com\n" - "Phone: (650) 506-8127\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "E-mail: joel.becker at oracle.com\n" + Phone: (650) 506-8127 -d1c783633746be85363d27418d49d39c96b8b595d34687dc2c81886011c830c7 +c33e6e704d85aa5899e8955215f80b9687eacb38002c39ff1d9427fc211ca64c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.