From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] lib/power: fix error handling on setting
	governor
Date: Mon, 14 Jan 2019 23:45:37 +0100
Message-ID: <2010732.Y0ziD7SgTV@xps>
References: <20190108145926.37367-1-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, liang.j.ma@intel.com
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 079CE5B20
 for <dev@dpdk.org>; Mon, 14 Jan 2019 23:45:40 +0100 (CET)
In-Reply-To: <20190108145926.37367-1-david.hunt@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

08/01/2019 15:59, David Hunt:
> In the power_set_governor_*() functions, we using fputs() on /sys
> filesystem. However, we also need to call fflush() to ensure that
> the write completes successfully. Otherwise the attempt to set the
> power governor fails and the function returns as if it has
> succeeded. This patch adds an fflush to ensure that the
> write succeeds, otherwise returns an error.
> 
> Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility")
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>

Applied, thanks