From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, alan@linux.intel.com,
Harsha Priya <priya.harsha@intel.com>,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/4] ASoC sst: Add mid machine driver
Date: Sun, 2 Jan 2011 13:47:16 +0000 [thread overview]
Message-ID: <20110102134715.GE4935@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1293707593-8372-1-git-send-email-vinod.koul@intel.com>
On Thu, Dec 30, 2010 at 04:43:13PM +0530, Vinod Koul wrote:
> This patch adds the mic machine driver
> The mid machine driver glues the msic and mid_platfrom driver to form the asoc sound driver
So, this isn't actually doing any sort of interface with your BIOS or
otherwise doing anything system-specific. If this is intended to be
a generic driver that manages the interaction with your BIOS then I'd
expect to see something like that. If it's a driver for a specific
system then I'd expect the driver to say what it's a driver for.
Also, looking at your CODEC driver I'm not seeing anything that looks
like the handling for the three "nameless" CODEC vendors you've got -
given that you've got vendor workarounds in the code there this is
really surprising.
next prev parent reply other threads:[~2011-01-02 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 11:13 [PATCH 3/4] ASoC sst: Add mid machine driver Vinod Koul
2011-01-02 13:47 ` Mark Brown [this message]
2011-01-03 5:39 ` Koul, Vinod
2011-01-03 15:43 ` Mark Brown
2011-01-03 16:01 ` Koul, Vinod
2011-01-03 16:28 ` Mark Brown
2011-01-03 17:34 ` Koul, Vinod
2011-01-04 13:39 ` Mark Brown
2011-01-03 16:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110102134715.GE4935@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.