From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead
Date: Mon, 03 Jan 2011 05:34:51 +0000 [thread overview]
Message-ID: <20110103053451.GO1886@bicker> (raw)
In-Reply-To: <1294006469-4400-1-git-send-email-martinez.javier@gmail.com>
On Sun, Jan 02, 2011 at 11:14:25PM +0100, Javier Martinez Canillas wrote:
> This patchset make some cleanup to staging/keucr. Use memcmp and memcpy instead of custom functions.
> Also some style cleanups recomended by Dan Carpenter, Joe Perches and Gábor Stefanik.
>
> The patches in this patchset are the following:
>
> [PATCH 1/4] staging: keucr: Use memcmp() instead custom StringCmp() and some style cleanups
> [PATCH 2/4] staging: keucr: Use memcpy() instead custom StringCopy() and some style cleanups
> [PATCH 3/4] staging: keucr: Delete StringCmp() and StringCopy custom functions
> [PATCH 4/4] staging: keucr: Delete use kernel strcmp() & strcpy() from TODO file
>
Looks good. v1 made me grumpy. v2 was ok. v4 is what all patches
should look like. :)
Acked-by: Dan Carpenter <error27@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-01-03 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 22:14 [PATCHv4 0/4] staging: keucr: Use memcmp() & memcpy() instead of custom String[Cmp|Copy] functions Javier Martinez Canillas
2011-01-03 5:34 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103053451.GO1886@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.