From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 03 Jan 2011 05:48:33 +0000 Subject: [patch] [SCSI] scsi_dh: potential null dereference in Message-Id: <20110103054833.GT1886@bicker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "James E.J. Bottomley" Cc: Mike Snitzer , Menny Hamburger , Babu Moger , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org We assumed "sdev" could be NULL ealier, so lets check it here as well. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c index b837c5b..ff340e3 100644 --- a/drivers/scsi/device_handler/scsi_dh.c +++ b/drivers/scsi/device_handler/scsi_dh.c @@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data) sdev->sdev_state = SDEV_CANCEL || sdev->sdev_state = SDEV_DEL) err = SCSI_DH_NOSYS; - if (sdev->sdev_state = SDEV_OFFLINE) + if (sdev && sdev->sdev_state = SDEV_OFFLINE) err = SCSI_DH_DEV_OFFLINED; spin_unlock_irqrestore(q->queue_lock, flags); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] [SCSI] scsi_dh: potential null dereference in scsi_dh_activate() Date: Mon, 3 Jan 2011 08:48:33 +0300 Message-ID: <20110103054833.GT1886@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:65178 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150Ab1ACFsp (ORCPT ); Mon, 3 Jan 2011 00:48:45 -0500 Content-Disposition: inline Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "James E.J. Bottomley" Cc: Mike Snitzer , Menny Hamburger , Babu Moger , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org We assumed "sdev" could be NULL ealier, so lets check it here as well. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c index b837c5b..ff340e3 100644 --- a/drivers/scsi/device_handler/scsi_dh.c +++ b/drivers/scsi/device_handler/scsi_dh.c @@ -446,7 +446,7 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data) sdev->sdev_state == SDEV_CANCEL || sdev->sdev_state == SDEV_DEL) err = SCSI_DH_NOSYS; - if (sdev->sdev_state == SDEV_OFFLINE) + if (sdev && sdev->sdev_state == SDEV_OFFLINE) err = SCSI_DH_DEV_OFFLINED; spin_unlock_irqrestore(q->queue_lock, flags);