From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"Harsha, Priya" <priya.harsha@intel.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] ASoC sst: Add msic codec driver
Date: Mon, 3 Jan 2011 15:44:30 +0000 [thread overview]
Message-ID: <20110103154430.GD6783@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <438BB0150E931F4B9CE701519A44630104C10F2EC1@bgsmsx502.gar.corp.intel.com>
On Mon, Jan 03, 2011 at 09:06:56PM +0530, Koul, Vinod wrote:
> > There's quite a few places where there are coding style issues, in
> > general if your code doesn't look like other kernel code that's a
> > problem. One of the most frequent issues was that you weren't using
> > spaces around /* and */.
> Checkpatch doesn't seem to catch these, have fixed them now.
> Any other inconsistency you noted which may not be detected by checkpatch
I'll point them out when I notice them; like I say this is something you
should be able to check by comparing with other code.
prev parent reply other threads:[~2011-01-03 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 11:12 [PATCH 1/4] ASoC sst: Add msic codec driver Vinod Koul
2011-01-02 13:33 ` Mark Brown
2011-01-03 5:30 ` Koul, Vinod
2011-01-03 15:25 ` Mark Brown
2011-01-03 15:36 ` Koul, Vinod
2011-01-03 15:44 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103154430.GD6783@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.