Re: Need to disable MSR interrupts in 8250 driver. Request for guidance...

[Greg KH <gregkh@suse.de>]

On Mon, Jan 03, 2011 at 03:56:45PM -0800, Kevin Hilman wrote:
> Michael Williamson <michael.williamson@criticallink.com> writes:
> 
> > I am working on platform from the davinci architecture that uses the 8520 UART
> > driver.  However, there are some configurations that do not have a valid
> > CTS input pin (it is a multi-purpose pin on a SoC part, and it may be configured
> > for other functions).  These configurations can cause a pile of "false" 
> > MSR interrupts.  If, in 8250.c, I set the UART_BUG_NOMSR flag as part of
> > the up->bugs information, the problem clears up.
> 
> [...]
> 
> > Should I create a new port type, add a new UPF_ flag in the flags field, figure 
> > out how to pass bugs information via platform data, or continue along the
> > work-around path?  
> 
> I added Greg KH to Cc as he's maintaining the 8250 core now.
> 
> IMO, adding UPF_ flag(s) to indicate this bug seems like the right way
> to go to me.

Yes, it sounds correct to me as well.

thanks,

greg k-h