From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: add FITRIM support
Date: Tue, 4 Jan 2011 11:15:18 +1100 [thread overview]
Message-ID: <20110104001518.GG15179@dastard> (raw)
In-Reply-To: <20110102072202.GA26488@infradead.org>
On Sun, Jan 02, 2011 at 02:22:02AM -0500, Christoph Hellwig wrote:
> Allow manual discards from userspace using the FITRIM ioctl. This is not
> intended to be run during normal workloads, as the freepsace btree walks
> can cause large performance degradation.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> ---
>
> V1 -> V2
>
> - added __user annotations as noted by Alex
> - removed non-blocking agf read as noted by Alex
> - update range->len as noted by Alex
>
> This does not implement the by-bno search or lock break suggestions from
> Dave. Given that the 2.6.38 window is about to close those seem a bit
> risky to me. I'll look into these later.
Ok, seemms like a good way to proceed.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-04 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 7:22 [PATCH] xfs: add FITRIM support Christoph Hellwig
2011-01-04 0:15 ` Dave Chinner [this message]
2011-01-04 21:55 ` Alex Elder
2011-01-06 18:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104001518.GG15179@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.