Re: [PATCH v3 1/4] TI816X: Update common omap platform files

[Tony Lindgren <tony@atomide.com>]

* Paul Walmsley <paul@pwsan.com> [110103 15:06]:
> Hello Hemant 
> 
> On Mon, 3 Jan 2011, Hemant Pedanekar wrote:
> 
> > This patch updates the common platform files with TI816X support. Also adds new
> > files for TI816X modules base addresseses and irq definitions.
> > 
> > The approach taken in this patch is to add TI816X as part of OMAP3 variant where
> > the cpu class is considered as OMAP34XX and the type is TI816X. This means, both
> > cpu_is_omap34xx() and cpu_is_ti816x() checks return success on TI816X.
> 
> Looks like you should add a CONFIG_ARCH_OMAPTI816X Kconfig option for this 
> chip.  I suspect that many handheld device manufacturers won't want to 
> include TI816X-specific code/data in their builds, and vice versa.

Please use CONFIG_SOC_OMAPTI816X instead, eventually we should use
CONFIG_ARCH_OMAPX only for something that requires different compiler
options.

Regards,

Tony