Re: [PATCH] repair: warn if running in low memory mode

From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] repair: warn if running in low memory mode
Date: Tue, 4 Jan 2011 04:52:56 -0500	[thread overview]
Message-ID: <20110104095256.GA26885@infradead.org> (raw)
In-Reply-To: <1294121563-17150-1-git-send-email-david@fromorbit.com>

On Tue, Jan 04, 2011 at 05:12:43PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> When checking large filesystems, xfs_repair makes an estimate of how
> much RAM it will need to execute effectively. If the amount of RAM
> is less than this, it reduces the bhash size and turns of
> prefetching, which will substantially slow down the repair process.
> Add a warning that indicates this is happening, along with a
> recommendation of how much RAM repair calculates it needs to run
> with prefetching enabled.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

> +				do_warn(_("Not enough RAM available for repair "
> +					"to enable prefetching. This will be "
> +					"_slow_.\n"
> +					"You need at least %luMB RAM to run "
> +					"with prefetching enabled."),
> +					mem_used * 1280 / (1024 * 1024));

Maybe but the strings on a separate line to be easier readable and
greppable, e.g.:

				do_warn(
	_("Not enough RAM available for repair to enable prefetching. "
	  "This will be _slow_.\n"
	  "You need at least %luMB RAM to run with prefetching enabled."),

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs