Re: [PATCH] vtdt: add a missing change (RE: Re: xen guest hang with TSC_DEADLINE)

[Christoph Egger <Christoph.Egger@amd.com>]

On Monday 27 December 2010 04:05:41 Wei, Gang wrote:
> Christoph Egger wrote on 2010-12-20:
> >>> c/s 22529 and 22530 cause a xen guest hang.
> >>>
> >>> While "normal" guests like Linux and NetBSD boot fine I boot Xen
> >>> itself as a xen guest for my nested virtualization.
> >>>
> >>> When I do that then the guest dom0 hangs at boot when it tries to
> >>> initialize the first vcpu.
> >>> The bug is introduced somewhere in c/s 22529 and triggers with c/s
> >>> 22530.
> >>
> >> Can you enable apic_timer debug info var hvm_debug and give more
> >> serial port log around the guest dom0 hangs? I used to test xen
> >> guest, it works well expect that it boot a little bit slowly.
> >
> > This is the log output I get with TSC_DEADLINE feature enabled:
>
> Just found one change was missed while the whole patch was checked in.
> Apply below patch, it should be ok now.
>
> diff -r 0133cf2a72f5 xen/arch/x86/hvm/vlapic.c
> --- a/xen/arch/x86/hvm/vlapic.c	Fri Dec 24 10:56:29 2010 +0000
> +++ b/xen/arch/x86/hvm/vlapic.c	Tue Dec 28 16:53:06 2010 +0800
> @@ -56,7 +56,7 @@ static unsigned int vlapic_lvt_mask[VLAP
>  static unsigned int vlapic_lvt_mask[VLAPIC_LVT_NUM] =
>  {
>       /* LVTT */
> -     LVT_MASK | APIC_TIMER_MODE_PERIODIC,
> +     LVT_MASK | APIC_TIMER_MODE_MASK,
>       /* LVTTHMR */
>       LVT_MASK | APIC_MODE_MASK,
>       /* LVTPC */
>
> Jimmy

The hang is still reproducable with this change. Sorry.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632