From: Jakub Narebski <jnareb@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, John 'Warthog9' Hawley <warthog9@kernel.org>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 2/2] gitweb: make logo optional
Date: Tue, 4 Jan 2011 12:52:39 +0100 [thread overview]
Message-ID: <201101041252.40254.jnareb@gmail.com> (raw)
In-Reply-To: <20110104050555.GC8280@burratino>
On Tue, 4 Dec 2011, Jonathan Nieder wrote:
> Some sites may not want to have a logo at all. In particular, git
> instaweb can benefit from this.
Why do you think that git-instaweb can benefit from not having logo?
You need gitweb.css anyway, so it is not much more trouble to serve
additional static file, git-logo.png.
>
> While at it, use $cgi->img to simplify this code. (CGI.pm learned
> most HTML4 tags by version 2.79, so this should be portable to perl
> 5.8, though I haven't tested.)
corelist (Module::CoreList) says that Perl 5.8.0 has CGI.pm version 2.81;
IIRC gitweb requires something later than 5.8.0 for good support of
Unicode (Encode module).
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
For what it is worth it:
Acked-by: Jakub Narebski <jnareb@gmail.com>
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-01-04 11:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 5:02 [PATCH 0/2] gitweb: make logo optional Jonathan Nieder
2011-01-04 5:02 ` [PATCH 1/2] gitweb: skip logo in atom feed when there is none Jonathan Nieder
2011-01-05 0:25 ` Jakub Narebski
2011-01-05 0:45 ` Junio C Hamano
2011-01-04 5:05 ` [PATCH 2/2] gitweb: make logo optional Jonathan Nieder
2011-01-04 11:52 ` Jakub Narebski [this message]
2011-01-04 16:29 ` Jonathan Nieder
2011-01-04 23:24 ` [PATCH 0/2] " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101041252.40254.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.