From: Stephen Hemminger <shemminger@vyatta.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Mahesh Bandewar <maheshb@google.com>,
David Miller <davem@davemloft.net>,
Laurent Chavey <chavey@google.com>,
Tom Herbert <therbert@google.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] net: Allow ethtool to set interface in loopback mode.
Date: Tue, 4 Jan 2011 17:53:58 -0800 [thread overview]
Message-ID: <20110104175358.5e15b901@nehalam> (raw)
In-Reply-To: <4D23CAA5.7060902@hp.com>
On Tue, 04 Jan 2011 17:34:29 -0800
Rick Jones <rick.jones2@hp.com> wrote:
> >>>Since this is a boolean it SHOULD go into ethtool_flags rather than
> >>>being a high level operation.
> >>
> >>It could do, but I though ETHTOOL_{G,S}FLAGS were intended for
> >>controlling offload features.
> >
> >
> > It just seems the number of hooks keeps growing which takes more space
> > and increases complexity.
>
> Is there any complication/downside to using flags in the (un?)likely event of
> wanting different flavors of loopback in the card?
>
> rick jones
Then let is keep it as command and have a parameter to set mode.
There might be drivers that want to loopback in SW, HW, PHY or even switch.
--
next prev parent reply other threads:[~2011-01-05 1:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 8:00 [PATCH] Net-ethtool : Allow ethtool to set interface in loopback mode Mahesh Bandewar
2010-11-30 9:48 ` Simon Horman
2010-11-30 15:01 ` Ben Hutchings
2010-11-30 19:05 ` Mahesh Bandewar
2010-11-30 19:15 ` Ben Hutchings
2010-11-30 21:22 ` Mahesh Bandewar
2010-11-30 23:57 ` [PATCH v2] " Mahesh Bandewar
2010-12-01 14:54 ` Ben Hutchings
2010-12-01 20:14 ` [PATCH v3] " Mahesh Bandewar
2010-12-01 20:17 ` Ben Hutchings
2010-12-10 4:11 ` David Miller
2011-01-05 0:30 ` [PATCH v2] net: " Mahesh Bandewar
2011-01-05 0:36 ` Stephen Hemminger
2011-01-05 1:21 ` Ben Hutchings
2011-01-05 1:29 ` Stephen Hemminger
2011-01-05 1:34 ` Rick Jones
2011-01-05 1:53 ` Stephen Hemminger [this message]
2011-01-05 1:59 ` Ben Hutchings
2011-01-05 2:06 ` Mahesh Bandewar
2011-01-05 1:39 ` Mahesh Bandewar
2011-01-05 16:22 ` Jeff Garzik
2011-01-06 22:13 ` Ben Hutchings
2011-01-07 0:47 ` Mahesh Bandewar
2011-01-07 1:30 ` Ben Hutchings
2011-01-12 19:24 ` Mahesh Bandewar
2011-01-22 0:23 ` [PATCH v4] net-next-2.6: " Mahesh Bandewar
2011-01-23 2:35 ` Ben Hutchings
2011-01-23 17:12 ` Mahesh Bandewar
2011-01-23 17:32 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104175358.5e15b901@nehalam \
--to=shemminger@vyatta.com \
--cc=bhutchings@solarflare.com \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.